-
Notifications
You must be signed in to change notification settings - Fork 35
Add PTB HLT and LLT information to CAF files for real SBND data #614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Add PTB HLT and LLT information to CAF files for real SBND data #614
Conversation
fjnicolas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @hbjamin! See comment in SBNSoftware/sbnanaobj#180 about uint64_t for the decoded HLT/LLT IDs
terezakroupa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Ben, looks great!
PetrilloAtWork
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have dropped a few technical suggestions.
But more importantly I would like the author to deeply think about the real need for a catch(...) in the code.
|
Thank you for the good suggestions. There was no reason for me to use a catch statement. It was leftover from my initial debugging of |
Description
This PR adds PTB information to CAF files for real SBND data, which is required for trigger efficiency studies using zero bias data. The implementation extracts all HLT (High Level Trigger) and LLT (Low Level Trigger) information from PTB fragments, decodes trigger words into individual bits, and stores them separately in the CAF structure. This PR requires merging SBNSoftware/sbnanaobj#180