Release 7.12.1 #37437
Release 7.12.1 #37437
Conversation
🦋 Changeset detectedLatest commit: 8cbd9bf The changes in this PR will be included in the next version bump. This PR includes changesets to release 42 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
WalkthroughAdds multiple changes: new changeset files; switches apps-engine Deno runtime debug formatting from Changes
Sequence Diagram(s)sequenceDiagram
participant Msg as Inbound Message
participant Hook as leadCapture hook
participant Safe as safeMatch/uniq
participant Model as saveGuestEmailPhoneById
participant DB as LivechatVisitors model
Msg->>Hook: message arrives
Hook->>Safe: run safeMatch for phone/email
Safe-->>Hook: matchedPhones, matchedEmails
alt matches found
Hook->>Model: saveGuestEmailPhoneById(id, phones, emails)
Model->>DB: $set with $setUnion / $ifNull
DB-->>Model: update result
Model-->>Hook: result
else no matches
Hook-->>Msg: continue without saving
end
sequenceDiagram
participant Runtime as AppsEngineDenoRuntime
participant Messenger as ProcessMessenger
participant Deno as Deno subprocess
Runtime->>Runtime: inspect(message) -> debug log string
Runtime->>Messenger: send(message)
Messenger->>Deno: encoder.write(...)
Messenger->>Deno: deno.stdin.write(...)
Note over Messenger: constructor no longer receives debug.Debugger
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #37437 +/- ##
==========================================
+ Coverage 66.51% 66.55% +0.03%
==========================================
Files 3392 3392
Lines 115843 115843
Branches 21393 21392 -1
==========================================
+ Hits 77052 77098 +46
+ Misses 36113 36067 -46
Partials 2678 2678
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
…37440) Co-authored-by: Douglas Gubert <[email protected]>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.changeset/real-hotels-sniff.md (1)
6-6: Consider elaborating the description slightly for clarity.The description accurately summarizes the fix, but you might enhance it by mentioning the specific implementation detail (replacing
%Odebug formatting withutil.inspect) or the affected module (AppsEngine Deno runtime). This helps future maintainers quickly locate the corresponding code changes.Example revision:
-Fixes a problem in apps-engine debug logs where only 2 depth levels were displayed for objects, which is often not enough for debugging purposes +Fixes a problem in AppsEngine Deno runtime debug logs where only 2 depth levels were displayed for objects, by replacing `%O` formatting with `util.inspect` for improved debugging visibilitypackages/apps-engine/src/server/runtime/deno/AppsEngineDenoRuntime.ts (1)
554-554: Optional: Remove redundant inspect() on string.
error.messageis already a string, so wrapping it ininspect()is unnecessary (though harmless).Consider simplifying:
- this.debug('Error executing bridge method %s().%s() %s', bridgeName, bridgeMethod, inspect(error.message)); + this.debug('Error executing bridge method %s().%s() %s', bridgeName, bridgeMethod, error.message);
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Jira integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (3)
.changeset/real-hotels-sniff.md(1 hunks)packages/apps-engine/src/server/runtime/deno/AppsEngineDenoRuntime.ts(10 hunks)packages/apps-engine/src/server/runtime/deno/ProcessMessenger.ts(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: cardoso
Repo: RocketChat/Rocket.Chat PR: 36942
File: apps/meteor/client/lib/e2ee/keychain.ts:148-156
Timestamp: 2025-10-16T21:09:51.816Z
Learning: In the RocketChat/Rocket.Chat repository, only platforms with native crypto.randomUUID() support are targeted, so fallback implementations for crypto.randomUUID() are not required in E2EE or cryptographic code.
Learnt from: CR
Repo: RocketChat/Rocket.Chat PR: 0
File: .cursor/rules/test-cases.mdc:0-0
Timestamp: 2025-09-16T22:09:18.041Z
Learning: Use Rocket.Chat primary documentation and provided reference files for guidance
🧬 Code graph analysis (1)
packages/apps-engine/src/server/runtime/deno/AppsEngineDenoRuntime.ts (1)
packages/apps-engine/src/server/runtime/deno/ProcessMessenger.ts (1)
ProcessMessenger(8-54)
🔇 Additional comments (5)
.changeset/real-hotels-sniff.md (1)
1-6: Well-formed changeset entry.The changeset correctly documents the patch-level version bumps and provides a clear description of the debug logging fix. The entry aligns with the PR objective and the related runtime changes mentioned in the AI summary.
packages/apps-engine/src/server/runtime/deno/ProcessMessenger.ts (1)
15-17: LGTM! Constructor refactored correctly.The parameterless constructor aligns with the updated instantiation at line 127 of AppsEngineDenoRuntime.ts and removes the unused debug dependency.
packages/apps-engine/src/server/runtime/deno/AppsEngineDenoRuntime.ts (3)
4-4: LGTM! Inspect helper improves debug output control.The import and helper function provide consistent, single-line formatting for complex objects in debug logs with configurable depth, addressing the debug log depth display issue mentioned in the changelog.
Also applies to: 25-25
127-127: LGTM! Instantiation matches updated constructor.The parameterless constructor call correctly aligns with the refactored ProcessMessenger constructor signature.
184-184: LGTM! Consistent use of inspect() for complex objects.The inspect() helper is appropriately applied to complex objects and arrays (options, environment, messages, params, data) across debug statements, providing better readability and consistent formatting.
Also applies to: 330-330, 431-431, 529-529, 649-649, 698-698
…eady registered (#37436) Co-authored-by: Kevin Aleman <[email protected]>
Summary by CodeRabbit
Chores
Bug Fixes
Tests
You can see below a preview of the release change log:
7.12.1
Engine versions
22.16.01.43.55.0, 6.0, 7.01.57.1Patch Changes
Bump @rocket.chat/meteor version.
(#37436 by @dionisio-bot) Fixes the capture of lead's email or phone number when the visitor didn't have data already
(#37440 by @dionisio-bot) Fixes a problem in apps-engine debug logs where only 2 depth levels were displayed for objects, which is often not enough for debugging purposes
Updated dependencies [8cbd9bf, e6cc073]: