Skip to content

Stop forcing the custom elements polyfill in tests. #5607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
bicknellr wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Stop forcing the custom elements polyfill in tests. #5607

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
42d3131
Stop forcing the custom elements polyfill in browsers that natively s…
bicknellr Nov 18, 2019
3abcdd1
Remove unused code.
bicknellr Nov 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 0 additions & 18 deletions test/runner.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,30 +102,12 @@
return previous + (previous ? '&' : '') + next;
}

// test shadowdom/custom elements polyfills together
// preferring both if possible.
let flags = [''];
if (window.customElements) {
// NOTE: disabled because Native ShadowDOM and Polyfilled CustomElements is not an expected use-case.
// flags.push('wc-ce=true');
}
// if native is available, make sure to test polyfill
if (Element.prototype.attachShadow && Node.prototype.getRootNode) {
flags.push('wc-shadydom=true');
}
// Both sd and ce are supported, force both polyfills
if (flags.length === 2) {
// ce + sd becomes a single test iteration.
flags.push('wc-ce=true&wc-shadydom=true');
}

// economize testing by testing css shimming
// only against 1 environment (native or polyfill).
if (window.CSS && CSS.supports && CSS.supports('box-shadow', '0 0 0 var(--foo)')) {
// Note: Disabled to speed up testing, may be reenabled at a later date when the test timing is less of an issue.
// let last = flags.length === 1 ? '' : flags[flags.length - 1];
// flags.push(addUrlOption(last, 'wc-shimcssproperties=true'));
}
suites = combinations(suites, flags);
console.log('Testing suites:\n\t' + suites.join('\n\t'));

Expand Down