Open
Conversation
- now includes an "include" directory - bin directory was moved a while ago one level up
- now it points to the actual package root, not the utils directory - since we're using os.join, we should use it for all path separators
- only used in a test, not even to get the bin dir but the lib dir - add catalyst dialects build dir to the default lib paths
The catalyst binary used to be shipped right within the package, under catalyst/bin. This is no longer the case, and now pip will install the binary into the dedicated binary folder for Python packages. However, we may still encounter a configuration where the binary is located in a bin folder next to the catalyst package folder, specifically: - after `make wheel` we'll have frontend/bin next to frontend/catalyst, although we rarely directly test this configuration since it's more of a setup to packaging the wheel. - when trying to emulate the above configuration for a quick frontend-only editable install, e.g. by extracting wheel contents over a checked out catalyst repo.
Contributor
|
Hello. You may have forgotten to update the changelog!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes:
Fix cleanup of wheel artifacts
includedirectorybindirectory was moved a while ago one level upFix misleading
package_rootvariableutilsdirectoryos.join, we should use it for all path separatorsRemove obsolete
get_bin_dirfunctionbindir but thelibdirAdd cli path fallback for rare wheel setups
The catalyst binary used to be shipped right within the package, under
catalyst/bin. This is no longer the case, since pip will install the
binary into the dedicated binary location for Python packages.
However, we may still encounter a configuration where the binary is
located in a bin folder next to the catalyst package folder,
specifically:
make wheelwe'll have frontend/bin next to frontend/catalyst,although we rarely directly test this configuration since it's more
of a setup step to packaging the wheel.
frontend-only editable install, e.g. by extracting wheel contents
over a checked-out catalyst repo.