-
Notifications
You must be signed in to change notification settings - Fork 13
Feature/dl cluster splitting release #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feature/rsdc_milestone_1_2
Are you sure you want to change the base?
Feature/dl cluster splitting release #18
Conversation
AndyChappell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Isobel, thanks for the PR. Mostly formatting and stylistic requests, with a little refactoring and one more substantive point re garbage collection. Otherwise I think this is looking good.
AndyChappell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updates look good, thanks Isobel.
Hello hello,
In this PR I add the cluster splitting model training scripts to the LArMachineLearningData repository. There are two models used in the cluster splitting algorithm: 1) ContaminationModel, used to determine whether a cluster 'window' is shower-like, contaminated or not contaminated, and 2) SplitPointModel, used to classify each position in a window as a signal/background split point. The scripts should be ran in this order:
(The training of the encoder and encoder-decoder is orthogonal, so steps 3/4 and 5/6 can be swapped).
The other files are:
Let me know if you have any questions!