Skip to content

Conversation

@1q07
Copy link

@1q07 1q07 commented Jan 9, 2026

add unim 4Gbit single die config table

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


1q07 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 9, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Comment on lines 599 to +605
nand_pagesize = HAL_NAND_PAGE_SIZE(&spi_nand_handle.handle);
nand_blksize = HAL_NAND_BLOCK_SIZE(&spi_nand_handle.handle);
if(spi_nand_handle.dev_id == 0xb034b0)
{
nand_pagesize = 4096;
nand_blksize = 0x80000;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
nand_pagesize = HAL_NAND_PAGE_SIZE(&spi_nand_handle.handle);
nand_blksize = HAL_NAND_BLOCK_SIZE(&spi_nand_handle.handle);
if(spi_nand_handle.dev_id == 0xb034b0)
{
nand_pagesize = 4096;
nand_blksize = 0x80000;
}
if(spi_nand_handle.dev_id == 0xb034b0)
{
nand_pagesize = 4096;
nand_blksize = 0x80000;
}
else
{
nand_pagesize = HAL_NAND_PAGE_SIZE(&spi_nand_handle.handle);
nand_blksize = HAL_NAND_BLOCK_SIZE(&spi_nand_handle.handle);
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants