build: Makefile hardening and maintainability improvements #1890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add .submodules target that auto-inits git submodules if missing - Make .setup and with-toolchain depend on submodules being ready - Fix docker pull to skip if image exists locally (ARM64 Mac compat)
- Replace bare 'make' with $(MAKE) in 14 places to properly propagate flags like --dry-run, --keep-going, etc. to sub-makes - Add build timing: display elapsed seconds at end of 'dist' target - Refactor core: target to use CORE_COMPONENTS variable for maintainability - Add TODO explaining why parallel builds don't work (shared .o files) - Keep 'with-toolchain' using bare 'make' since $(MAKE) expands to host path - Use portable sed (temp file) instead of GNU-only 'sed -i' - Quote glob in clean target to prevent shell expansion issues - Add print-version to .PHONY declaration - Extract INSTALLER_BINS variable for DRY installer binary copies
- Expand .PHONY with all missing targets (toolchain, git-submodules, etc.) - Add error handling to shell loops with '|| exit 1' for fail-fast behavior - Make deepclean resilient to missing submodules - Add consistent @ prefix to .docker target and test runner - Clean .d dependency files in addition to .o files - Extract variables for maintainability: THIRD_PARTY_COMPONENTS, SIMPLE_APPS - Sort all component lists alphabetically
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modernizes the Onion Makefile with better maintainability, error handling, and cross-platform compatibility.
Changes
Build Reliability
makewith$(MAKE)in 14 places — enables proper flag propagation (--dry-run,--keep-going,-j)|| exit 1to shell loops for fail-fast behavior on component build failuresdeepcleanresilient to missing git submodulesCross-Platform Compatibility
sedpattern (temp file) instead of GNU-onlysed -iMaintainability
CORE_COMPONENTS— 27 core binariesINSTALLER_BINS— 7 installer binariesSIMPLE_APPS— apps that build to BIN_DIRTHIRD_PARTY_COMPONENTS— external projectsHygiene
.PHONYwith all missing targets@prefix for quiet output.ddependency files in addition to.odistTesting
make with-toolchain CMD="build"completes successfullymake cleanandmake deepcleanwork correctly