Skip to content

Conversation

@summerx96
Copy link
Contributor

Summary

Separates general instruction-following from summarization so non-summary prompts no longer get a default "Summarize …" system instruction.

Why

Structured extraction/ranking prompts were being sent through summarize(), which injects a default summarization system prompt when system_prompt is omitted. That causes the model to summarize instructions instead of executing them and leads to silent parse failures.

Changes

  • Add chat() to SDK + HTTP LLM clients and wrapper.
  • Switch non-summary call sites to chat() in memorize/retrieve/patch/crud.
  • Fix _summarize_segment() to pass segment text + summary system prompt.

Tests

  • Not run standalone for this PR; end-to-end run on the stacked branch (feat/gemini-httpx) with Gemini.

Note

If possible, please preserve commit authorship (avoid rewriting author) for contribution attribution.

@summerx96 summerx96 changed the title Add chat() API and stop misusing summarize() fix: add chat() API and stop misusing summarize() Jan 10, 2026
@summerx96 summerx96 force-pushed the fix/chat-vs-summarize branch from 931d040 to 6c4e6da Compare January 11, 2026 06:11
@summerx96 summerx96 force-pushed the fix/chat-vs-summarize branch from 6c4e6da to 5bf951e Compare January 13, 2026 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant