Add support for dynamic MIG config generation #2043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajathagasthya
force-pushed
the
dynamic-mig-config
branch
from
d775648 to
5e6bbc8
Compare
rajathagasthya
changed the title
rajathagasthya
requested review from
ArangoGutierrez,
cdesiniotis,
elezar,
shivamerla and
tariq1890
as code owners
Removes static, handcrafted MIG config file and uses config generated dynamically by mig-parted CLI, if a custom config is not specified. Signed-off-by: Rajath Agasthya <ragasthya@nvidia.com>
Test the conditional ConfigMap mounting logic for custom MIG config: * Unit tests verify volume, volumeMount, and CONFIG_FILE env var * Integration tests verify end-to-end daemonset creation Signed-off-by: Rajath Agasthya <ragasthya@nvidia.com>
rajathagasthya
force-pushed
the
dynamic-mig-config
branch
from
5e6bbc8 to
1e56440
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes static, handcrafted MIG config file and uses config generated dynamically by mig-parted CLI, if a custom config is not specified.
Checklist
make lint)make validate-generated-assets)make validate-modules)Testing
Tested by deplying MIG manager changes in NVIDIA/mig-parted#295 on nodes with different types of GPUs to verify generated config. More testing steps will be added later.