[TRTLLM-10016][infra] Use SlurmPatition attribute time as timeout threshold #10254
Conversation
|
/bot run |
|
PR_Github #29706 [ run ] triggered by Bot. Commit: |
|
PR_Github #29706 [ run ] completed with state
|
|
/bot run |
|
PR_Github #29786 [ run ] triggered by Bot. Commit: |
|
PR_Github #29786 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
Signed-off-by: Yiqing Yan <[email protected]>
yiqingy0
force-pushed
the
add_attribute_time
branch
from
2789ff5 to
130a0d1
Compare
|
/bot run --disable-fail-fast |
|
PR_Github #30088 [ run ] triggered by Bot. Commit: |
|
PR_Github #30088 [ run ] completed with state
|
|
/bot run |
|
PR_Github #30110 [ run ] triggered by Bot. Commit: |
📝 WalkthroughWalkthroughJenkins L0_Test.groovy now accepts and propagates Slurm partition timeout values through Docker and Enroot runtime methods. Timeout logic was updated to derive from partition configuration instead of a constant default. Library imports and error handling for container cleanup were also adjusted. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~15 minutes Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (1)
jenkins/L0_Test.groovy (1)
3006-3012: Consider more robust error handling for container cleanup.The error handling for "Failed to kill container" has potential issues:
- String matching on error messages is fragile and may break with Docker version changes
- Could potentially mask legitimate container kill failures that need attention
- No logging of the ignored error for debugging purposes
🔎 Suggested improvement
} catch (Exception e) { if (e.getMessage()?.contains("Failed to kill container")) { - echo "Known benign error ignored: ${e.getMessage()}" + // Log the full error for debugging but don't fail the build + echo "WARNING: Benign Docker cleanup error ignored. This may indicate Docker daemon issues." + echo "Error details: ${e.getMessage()}" + echo "Stack trace: ${e.getStackTrace().join('\n')}" } else { throw e // Re-throw if it's a different Exception } }Consider documenting why this error is considered benign and under what conditions it occurs.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
jenkins/L0_Test.groovy
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: Funatiq
Repo: NVIDIA/TensorRT-LLM PR: 6754
File: tests/integration/test_lists/test-db/l0_a30.yml:41-47
Timestamp: 2025-08-13T11:07:11.772Z
Learning: In TensorRT-LLM test configuration files like tests/integration/test_lists/test-db/l0_a30.yml, TIMEOUT values are specified in minutes, not seconds.
Learnt from: yuanjingx87
Repo: NVIDIA/TensorRT-LLM PR: 7176
File: jenkins/L0_Test.groovy:361-389
Timestamp: 2025-08-22T19:08:10.822Z
Learning: In Slurm job monitoring scripts, when jobs have built-in timeouts configured (via --time parameter or partition/system timeouts), an additional timeout mechanism in the monitoring loop is typically unnecessary. When a Slurm job times out, it gets terminated and removed from the active queue, causing `squeue -j $jobId` to return non-zero and break monitoring loops naturally. The job's final status can then be checked via `sacct` to determine if it failed due to timeout.
Learnt from: fredricz-20070104
Repo: NVIDIA/TensorRT-LLM PR: 7785
File: tests/integration/defs/perf/utils.py:321-333
Timestamp: 2025-09-17T06:01:01.836Z
Learning: In test infrastructure code for disaggregated serving tests, prefer logging errors and continuing execution rather than raising exceptions on timeout, to avoid disrupting test cleanup and causing cascading failures.
📚 Learning: 2025-08-22T19:08:10.822Z
Learnt from: yuanjingx87
Repo: NVIDIA/TensorRT-LLM PR: 7176
File: jenkins/L0_Test.groovy:361-389
Timestamp: 2025-08-22T19:08:10.822Z
Learning: In Slurm job monitoring scripts, when jobs have built-in timeouts configured (via --time parameter or partition/system timeouts), an additional timeout mechanism in the monitoring loop is typically unnecessary. When a Slurm job times out, it gets terminated and removed from the active queue, causing `squeue -j $jobId` to return non-zero and break monitoring loops naturally. The job's final status can then be checked via `sacct` to determine if it failed due to timeout.
Applied to files:
jenkins/L0_Test.groovy
🔇 Additional comments (3)
jenkins/L0_Test.groovy (3)
3017-3017: All call sites forrunInEnrootOnNodeare correctly updated. The single invocation atslurmRunner = runInEnrootOnNode(nodeName, partitionTimeout)properly passes both thelabelandpartitionTimeoutparameters.
2988-2988: All call sites are properly updated with the newpartitionTimeoutparameter.The only invocation in the codebase (line 700) correctly passes
partitionTimeoutas the 4th argument. No broken call sites were found.
698-704: No action needed. BothrunInDockerOnNodeMultiStageandrunInEnrootOnNodealready apply identical timeout logic (timeout(time: partitionTimeout - 10, unit: 'MINUTES')), correctly reducing the partition timeout by 10 minutes before execution. The different defaults (DEFAULT_TIMEOUTvsDEFAULT_TIMEOUT_SHORT) are intentional for their respective container runtimes. Sincepartition.timecomes fromSlurmConfig.partitionConfig(configured externally in the shared library), validation at this point is unnecessary—the value is configuration-managed, not user-provided.Likely an incorrect or invalid review comment.
|
PR_Github #30110 [ run ] completed with state
|
Co-authored-by: Yanchao Lu <[email protected]> Signed-off-by: Yiqing Yan <[email protected]>
Co-authored-by: Yanchao Lu <[email protected]> Signed-off-by: Yiqing Yan <[email protected]>
Signed-off-by: Yiqing Yan <[email protected]>
|
/bot run --disable-fail-fast |
|
PR_Github #30140 [ run ] triggered by Bot. Commit: |
Signed-off-by: Yiqing Yan <[email protected]>
|
/bot run --disable-fail-fast |
|
PR_Github #30149 [ run ] triggered by Bot. Commit: |
|
PR_Github #30149 [ run ] completed with state |
|
/bot run --stage-list "DGX_B200-4_GPUs-PyTorch-Ray-1,DGX_B200-8_GPUs-PyTorch-1,DGX_B200-4_GPUs-PyTorch-Post-Merge-1,DGX_B200-4_GPUs-PyTorch-Post-Merge-2" --disable-fail-fast |
|
PR_Github #30187 [ run ] triggered by Bot. Commit: |
|
/bot run --stage-list "DGX_B200-4_GPUs-PyTorch-Ray-1,DGX_B200-8_GPUs-PyTorch-1,DGX_B200-4_GPUs-PyTorch-Post-Merge-1,DGX_B200-4_GPUs-PyTorch-Post-Merge-2" --disable-fail-fast --disable-reuse-test |
|
PR_Github #30188 [ run ] triggered by Bot. Commit: |
|
PR_Github #30188 [ run ] completed with state |
|
/bot run --stage-list "GB200-8_GPUs-2_Nodes-PyTorch-1,DGX_B200-4_GPUs-PyTorch-Post-Merge-1" --disable-fail-fast --disable-reuse-test |
|
PR_Github #30226 [ run ] triggered by Bot. Commit: |
|
PR_Github #30226 [ run ] completed with state |
Signed-off-by: Yiqing Yan <[email protected]>
Signed-off-by: Yiqing Yan <[email protected]>
|
/bot skip --comment "has been tested in /LLM/main/L0_MergeRequest_PR pipeline #23199, /LLM/main/L0_MergeRequest_PR pipeline #23234 (Partly Tested) and /LLM/main/L0_MergeRequest_PR pipeline #23269 (Partly Tested)" |
|
PR_Github #30246 [ skip ] triggered by Bot. Commit: |
|
PR_Github #30246 [ skip ] completed with state |
…eshold (NVIDIA#10254) Signed-off-by: Yiqing Yan <[email protected]> Co-authored-by: Yanchao Lu <[email protected]> Signed-off-by: Daniil Kulko <[email protected]>
4 participants
Summary by CodeRabbit
Release Notes
Chores
Bug Fixes
✏️ Tip: You can customize this high-level summary in your review settings.
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
Details
run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]Launch build/test pipelines. All previously running jobs will be killed.
--reuse-test (optional)pipeline-id(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.--disable-reuse-test(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-PyTorch-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--test-backend "pytorch, cpp"(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".--detailed-log(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.--debug(OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-listparameter to access the appropriate container environment. Note: Does NOT update GitHub check status.For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.mdand the
scripts/test_to_stage_mapping.pyhelper.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.