-
Notifications
You must be signed in to change notification settings - Fork 6
Ethany/resource listener golang #281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ethany-nv
wants to merge
13
commits into
feature/PROJ-147-operator-redesign
Choose a base branch
from
ethany/resource_listener_golang
base: feature/PROJ-147-operator-redesign
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Ethany/resource listener golang #281
ethany-nv
wants to merge
13
commits into
feature/PROJ-147-operator-redesign
from
ethany/resource_listener_golang
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced new message types: ResourceBody, ResourceUsageBody, and DeleteResourceBody in messages.proto. - Added ResourceListenerStream RPC in services.proto for handling node events and resource usage.
- Implemented multiple test cases for ResourceListenerStream, covering scenarios such as handling resource messages, resource usage messages, delete resource messages, and error handling. - Verified ACK message sending for different message types and ensured proper error handling for EOF and context cancellation. - Added tests for cases with missing or empty backend name metadata to ensure correct rejection of streams.
…e_listener_golang
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue #<issue number | "None">
Checklist