Skip to content

Conversation

@Wohox
Copy link
Contributor

@Wohox Wohox commented Jan 26, 2026

What does this PR do ?

This PR fixes the missing backward post hook bug, this bug happens when delay_wgrad_compute and cuda_graph are both enabled, the parameters within delayed wgrad computation scope will skip the backward post hook.

The fix is in TE, this PR only adds version guard and several flag assertions.
Related TE PR: NVIDIA/TransformerEngine#2614
PR for dev: #2999

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

@copy-pr-bot
Copy link

copy-pr-bot bot commented Jan 26, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@Wohox Wohox mentioned this pull request Jan 26, 2026
6 tasks
@Wohox Wohox added the bug Something isn't working label Jan 26, 2026
@Wohox Wohox changed the title [Draft][Main] fix cg missing wgrad hook (Draft)[Main] fix cg missing wgrad hook Jan 26, 2026
@Wohox Wohox marked this pull request as ready for review January 26, 2026 07:39
@Wohox Wohox requested review from a team as code owners January 26, 2026 07:39
@ko3n1g ko3n1g requested a review from a team January 26, 2026 07:40
@Wohox Wohox changed the title (Draft)[Main] fix cg missing wgrad hook [Main] fix cg missing wgrad hook Jan 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant