feat: Add kref-presence for E() on vat objects #754
+809
−129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| } | ||
| } | ||
| return arg; // Pass primitive through | ||
| }); |
There was a problem hiding this comment.
Nested presences not converted to kref strings in args
Medium Severity
The sendToKernel function only converts top-level presence objects to kref strings, not presences nested within objects or arrays. When calling E(presence).method({ nested: anotherPresence }), the nested presence won't be converted to its kref string before being passed to CapTP. This creates an asymmetry with convertKrefsToStandins on the kernel side, which does recursively convert nested kref strings. The nested presence may be incorrectly serialized by CapTP since it doesn't know about presences created by the presence manager.
rekmarks
force-pushed
the
rekm/caplet-implementation
branch
from
451a6dd to
605f8d9
Compare
rekmarks
force-pushed
the
rekm/kref-presence
branch
from
8b56b6b to
565d843
Compare
rekmarks
force-pushed
the
rekm/caplet-implementation
branch
from
605f8d9 to
f08383c
Compare
rekmarks
force-pushed
the
rekm/kref-presence
branch
from
565d843 to
544344e
Compare
rekmarks
force-pushed
the
rekm/caplet-implementation
branch
from
f08383c to
34a1f08
Compare
rekmarks
force-pushed
the
rekm/kref-presence
branch
from
544344e to
bad09bc
Compare
rekmarks
force-pushed
the
rekm/caplet-implementation
branch
from
34a1f08 to
4caf528
Compare
Set globalThis.kernel in the extension and omnium to the kernel itself. Remove ping and getKernel methods from background console interface. The kernel exposes ping().
…ects Implement slot translation pattern to enable E() (eventual sends) on vat objects from the extension background. This creates presences from kernel krefs that forward method calls to kernel.queueMessage() via the existing CapTP connection. Key changes: - Add background-kref.ts with makeBackgroundKref() factory - Add node-endoify.js to kernel-shims for Node.js environments - Update kernel-facade to convert kref strings to standins - Fix launch-subcluster RPC result to use null for JSON compatibility - Integrate resolveKref/krefOf into omnium background The new approach uses @endo/marshal with smallcaps format (matching the kernel) rather than trying to hook into CapTP internal marshalling, which uses incompatible capdata format. Co-Authored-By: Claude Opus 4.5 <[email protected]>
…ntegration Split the vitest configuration into two separate files to fix issues with tests running from the repo root: - vitest.config.ts: Unit tests with mock-endoify - vitest.integration.config.ts: Integration tests with node-endoify Add test:integration script to run integration tests separately. Co-Authored-By: Claude Opus 4.5 <[email protected]>
…helpers - Remove packages/nodejs/src/env/endoify.ts re-export, use @metamask/kernel-shims/node-endoify directly - Update vitest configs to use kernel-shims for setup files - Remove inline endoify imports from test files (now handled by vitest setup) - Fix test helpers to handle SubclusterLaunchResult return type from launchSubcluster() - Add kernel-shims dependency to kernel-test and nodejs-test-workers packages - Set coverage thresholds to 0 temporarily Co-Authored-By: Claude Opus 4.5 <[email protected]>
…e configs - Fix accidentally broken nodejs vat worker (which broke all tests relying on it) - Rename node-endoify.js to endoify-node.js for consistency - Update package.json export from ./node-endoify to ./endoify-node - Update all vitest configs to use the new export path - Update depcheckrc.yml ignore pattern Co-Authored-By: Claude Opus 4.5 <[email protected]>
- Import and initialize makeBackgroundKref to enable E() calls on vat objects - Expose captp.resolveKref and captp.krefOf on globalThis for console access - Refactor startDefaultSubcluster to return the bootstrap vat rootKref - Add greetBootstrapVat function that automatically calls hello() on the bootstrap vat after subcluster launch on startup - Update global.d.ts with captp type declaration for IDE support Co-Authored-By: Claude <[email protected]>
- Rename background-kref.ts to kref-presence.ts - Rename makeBackgroundKref to makePresenceManager - Rename BackgroundKref type to PresenceManager - Rename BackgroundKrefOptions to PresenceManagerOptions - Update all imports and references across affected packages - Update JSDoc comments to reflect new naming - All tests pass for kernel-browser-runtime, extension, omnium-gatherum Co-Authored-By: Claude <[email protected]>
…nvertKrefsToStandins - Move convertKrefsToStandins from kernel-facade.ts to kref-presence.ts for better organization - Export convertKrefsToStandins for use by kernel-facade - Add comprehensive unit tests for convertKrefsToStandins (20 tests covering kref conversion, arrays, objects, primitives) - Add unit tests for makePresenceManager (3 tests for kref resolution and memoization) - Add integration test in kernel-facade.test.ts verifying kref conversion in queueMessage Co-Authored-By: Claude <[email protected]>
rekmarks
force-pushed
the
rekm/kref-presence
branch
from
bad09bc to
88b8378
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Part 4 of 4 in PR stack for omnium-III
Depends on: #753
🤖 Generated with Claude Code
Note
Enables E()-style calls on vat objects and improves test/runtime setup across packages.
kref-presenceutilities: newmakePresenceManagerandconvertKrefsToStandins; exported from@metamask/kernel-browser-runtime; unit and integration tests addedglobalThis.kernelto a promise, attaches CapTPPresenceManageronglobalThis.captp/omnium(exposesresolveKref/krefOf), pings kernel on action, and greets bootstrap vat after launching default subclusterqueueMessageconverts kref strings to standins;launchSubclusterhandler returns JSON-compatible result with nullablebootstrapResult; tests updated@metamask/kernel-shims/endoify-node(optional@libp2p/webrtcpeer) and packages/tests switched to it; remove old local endoify importstest:integrationscript; GitHub Actions runs build + integrationWritten by Cursor Bugbot for commit 8b56b6b. This will update automatically on new commits. Configure here.