Skip to content

Conversation

@MetBenjaminWent
Copy link
Contributor

@MetBenjaminWent MetBenjaminWent commented Jan 30, 2026

Officiate the workaround so that Vernier can work out of the box at HoT without manual adjustments by users.

PR Summary

Sci/Tech Reviewer: @EdHone
Code Reviewer: @andrewcoughtrie

Code Quality Checklist

  • I have performed a self-review of my own code
  • My code follows the project's style guidelines
  • Comments have been included that aid understanding and enhance the readability of the code
  • My changes generate no new warnings
  • All automated checks in the CI pipeline have completed successfully

Testing

  • I have tested this change locally, using the LFRic Core rose-stem suite
  • If required (e.g. API changes) I have also run the LFRic Apps test suite using this branch
  • If any tests fail (rose-stem or CI) the reason is understood and acceptable (e.g. kgo changes)
  • I have added tests to cover new functionality as appropriate (e.g. system tests, unit tests, etc.)
  • Any new tests have been assigned an appropriate amount of compute resource and have been allocated to an appropriate testing group (i.e. the developer tests are for jobs which use a small amount of compute resource and complete in a matter of minutes)

trac.log

Test Suite Results - lfric_core - add_vernier_tag/run5

Suite Information

Item Value
Suite Name add_vernier_tag/run5
Suite User benjamin.went
Workflow Start 2026-02-02T09:29:39
Groups Run developer
Dependency Reference Main Like
lfric_core MetBenjaminWent/lfric_core@add_vernier_tag False
SimSys_Scripts MetOffice/[email protected] True

Task Information

✅ succeeded tasks - 370

Test Suite Results - lfric_apps - hot_testing/run6

Suite Information

Item Value
Suite Name hot_testing/run6
Suite User benjamin.went
Workflow Start 2026-01-30T13:28:35
Groups Run ex1a_omp_C48_cce_full
Dependency Reference Main Like
casim MetOffice/[email protected] True
jules MetOffice/[email protected] True
lfric_apps MetBenjaminWent/lfric_apps@9f301ea True
lfric_core MetBenjaminWent/lfric_core@4639446 True
moci MetOffice/[email protected] True
SimSys_Scripts MetOffice/[email protected] True
socrates MetOffice/[email protected] True
socrates-spectral MetOffice/[email protected] True
ukca MetOffice/[email protected] True

Task Information

❌ failed tasks - 3
Task State
check_lfric_atm_nwp_gal9_1T-C48_MG_ex1a_cce_full-debug-32bit failed
check_lfric_atm_nwp_gal9_4T-C48_MG_ex1a_cce_full-debug-32bit failed
kgo_groups_checker failed
✅ succeeded tasks - 10
  • (KGOs were not added for 1T and 4T. Do note 2T remains unchanged.

Outputs produced:
image

Security Considerations

  • I have reviewed my changes for potential security issues
  • Sensitive data is properly handled (if applicable)
  • Authentication and authorisation are properly implemented (if applicable)

Performance Impact

  • Performance of the code has been considered and, if applicable, suitable performance measurements have been conducted

AI Assistance and Attribution

  • Some of the content of this change has been produced with the assistance of Generative AI tool name (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the Simulation Systems AI policy (including attribution labels)

Documentation

  • Where appropriate I have updated documentation related to this change and confirmed that it builds correctly

PSyclone Approval

  • If you have edited any PSyclone-related code (e.g. PSyKAl-lite, Kernel interface, optimisation scripts, LFRic data structure code) then please contact the TCD Team

Sci/Tech Review

  • I understand this area of code and the changes being added
  • The proposed changes correspond to the pull request description
  • Documentation is sufficient (do documentation papers need updating)
  • Sufficient testing has been completed

(Please alert the code reviewer via a tag when you have approved the SR)

Code Review

  • All dependencies have been resolved
  • Related Issues have been properly linked and addressed
  • CLA compliance has been confirmed
  • Code quality standards have been met
  • Tests are adequate and have passed
  • Documentation is complete and accurate
  • Security considerations have been addressed
  • Performance impact is acceptable

@MetBenjaminWent MetBenjaminWent self-assigned this Jan 30, 2026
@github-actions github-actions bot added the cla-required The CLA has not yet been signed by the author of this PR - added by GA label Jan 30, 2026
@github-actions github-actions bot added cla-signed The CLA has been signed as part of this PR - added by GA and removed cla-required The CLA has not yet been signed by the author of this PR - added by GA labels Jan 30, 2026
@MetBenjaminWent MetBenjaminWent marked this pull request as ready for review January 30, 2026 14:49
name = 'Vernier'
if ( LPROF ) then
call vernier_init( communicator%get_comm_mpi_val() )
call vernier_init( communicator%get_comm_mpi_val(), tag='lfric' )
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make more sense to pass the application_name through as the tag to vernier?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could do, though this was just to get the workaround on trunk quick as opposed to a perfect solution.

Ideally we wouldn't worry at all about the tags.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think changing 'lfric' to trim(application_name) would make sense for this fix, just in case we get stuck using a hard-coded name for the long term if we never get around to reverting it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given its right there in the timing_mod anyway, I don't mind adding it.

@andrewcoughtrie, does this work as an alternative to 'lfric' ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running the tests now

Copy link
Contributor

@EdHone EdHone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with the way this is implemented - passing on to CR @andrewcoughtrie

Copy link
Collaborator

@andrewcoughtrie andrewcoughtrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me.

Copy link
Collaborator

@andrewcoughtrie andrewcoughtrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All is good and the tests pass.

@andrewcoughtrie andrewcoughtrie merged commit ba96576 into MetOffice:main Feb 2, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The CLA has been signed as part of this PR - added by GA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants