-
Notifications
You must be signed in to change notification settings - Fork 38
Add GH_SCALAR_ARRAY to argument_mod #223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add GH_SCALAR_ARRAY to argument_mod #223
Conversation
|
Hi @TeranIvy, this should now be ready for review since the equivalent PSyclone change has been merged |
TeranIvy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, @mo-alistairp! I would suggest a minor change in metadata reorder, please see inline.
I tested the fork, and all is fine.
TeranIvy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Retested the updated fork after the review change, and all is fine. Passing to @MetBenjaminWent for code review.
PR Summary
Sci/Tech Reviewer: @TeranIvy
Code Reviewer: @MetBenjaminWent
This pull request is necessary to add the GH_SCALAR_ARRAY metadata type into LFRic to support arrays of scalars in LFRic. This PR goes alongside the corresponding PSyclone implentation which adds this support (both stfc/PSyclone#1312 and stfc/PSyclone#3101).
Code Quality Checklist
(Some checks are automatically carried out via the CI pipeline)
style guidelines
readability of the code
Testing
using this branch
acceptable (e.g. kgo changes)
tests, unit tests, etc.)
and have been allocated to an appropriate testing group (i.e. the
developer tests are for jobs which use a small amount of compute resource
and complete in a matter of minutes)
trac.log
Test Suite Results - lfric_core - gh_scalar_array_arg_mod/run1
Suite Information
Task Information
✅ succeeded tasks - 372
Security Considerations
Performance Impact
performance measurements have been conducted
AI Assistance and Attribution
of Generative AI tool name (e.g., Met Office Github Copilot Enterprise,
Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the
Simulation Systems AI policy
(including attribution labels)
Documentation
confirmed that it builds correctly
PSyclone Approval
interface, optimisation scripts, LFRic data structure code) then please
contact the
[email protected]
Sci/Tech Review
Please alert the code reviewer via a tag when you have approved the SR
Code Review