Skip to content

Conversation

@mo-alistairp
Copy link

@mo-alistairp mo-alistairp commented Jan 16, 2026

PR Summary

Sci/Tech Reviewer: @TeranIvy
Code Reviewer: @MetBenjaminWent

This pull request is necessary to add the GH_SCALAR_ARRAY metadata type into LFRic to support arrays of scalars in LFRic. This PR goes alongside the corresponding PSyclone implentation which adds this support (both stfc/PSyclone#1312 and stfc/PSyclone#3101).

Code Quality Checklist

(Some checks are automatically carried out via the CI pipeline)

  • I have performed a self-review of my own code
  • My code follows the project's
    style guidelines
  • Comments have been included that aid understanding and enhance the
    readability of the code
  • My changes generate no new warnings

Testing

  • I have tested this change locally, using the LFRic Core rose-stem suite
  • If required (e.g. API changes) I have also run the LFRic Apps test suite
    using this branch
  • If any tests fail (rose-stem or CI) the reason is understood and
    acceptable (e.g. kgo changes)
  • I have added tests to cover new functionality as appropriate (e.g. system
    tests, unit tests, etc.)
  • Any new tests have been assigned an appropriate amount of compute resource
    and have been allocated to an appropriate testing group (i.e. the
    developer tests are for jobs which use a small amount of compute resource
    and complete in a matter of minutes)

trac.log

Test Suite Results - lfric_core - gh_scalar_array_arg_mod/run1

Suite Information

Item Value
Suite Name gh_scalar_array_arg_mod/run1
Suite User alistair.pirrie
Workflow Start 2026-01-19T10:24:41
Groups Run developer
Dependency Reference Main Like
lfric_core mo-alistairp/lfric_core@add_gh_scalar_array_to_argument_mod False
SimSys_Scripts MetOffice/[email protected] True

Task Information

✅ succeeded tasks - 372

Security Considerations

  • I have reviewed my changes for potential security issues
  • Sensitive data is properly handled (if applicable)
  • Authentication and authorisation are properly implemented (if applicable)

Performance Impact

  • Performance of the code has been considered and, if applicable, suitable
    performance measurements have been conducted

AI Assistance and Attribution

  • Some of the content of this change has been produced with the assistance
    of Generative AI tool name (e.g., Met Office Github Copilot Enterprise,
    Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the
    Simulation Systems AI policy
    (including attribution labels)

Documentation

  • Where appropriate I have updated documentation related to this change and
    confirmed that it builds correctly

PSyclone Approval

  • If you have edited any PSyclone-related code (e.g. PSyKAl-lite, Kernel
    interface, optimisation scripts, LFRic data structure code) then please
    contact the
    [email protected]

Sci/Tech Review

  • I understand this area of code and the changes being added
  • The proposed changes correspond to the pull request description
  • Documentation is sufficient (do documentation papers need updating)
  • Sufficient testing has been completed

Please alert the code reviewer via a tag when you have approved the SR

Code Review

  • All dependencies have been resolved
  • Related Issues have been properly linked and addressed
  • CLA compliance has been confirmed
  • Code quality standards have been met
  • Tests are adequate and have passed
  • Documentation is complete and accurate
  • Security considerations have been addressed
  • Performance impact is acceptable

@mo-alistairp mo-alistairp self-assigned this Jan 16, 2026
@github-actions github-actions bot added the cla-signed The CLA has been signed as part of this PR - added by GA label Jan 16, 2026
@mo-alistairp mo-alistairp marked this pull request as ready for review January 27, 2026 13:49
@mo-alistairp
Copy link
Author

Hi @TeranIvy, this should now be ready for review since the equivalent PSyclone change has been merged

Copy link

@TeranIvy TeranIvy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, @mo-alistairp! I would suggest a minor change in metadata reorder, please see inline.

I tested the fork, and all is fine.

@mo-alistairp mo-alistairp requested a review from TeranIvy January 28, 2026 11:44
Copy link

@TeranIvy TeranIvy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retested the updated fork after the review change, and all is fine. Passing to @MetBenjaminWent for code review.

@TeranIvy TeranIvy requested review from MetBenjaminWent and removed request for stevemullerworth January 28, 2026 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The CLA has been signed as part of this PR - added by GA enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants