Skip to content

Conversation

@cpelley
Copy link
Collaborator

@cpelley cpelley commented Feb 25, 2025

  • ENH: Page theme toggle.
System dark theme System light theme System dark, light override using toggle*1

*1 Note how the mermaid diagram does not as of yet change theme with toggle.
The same would be true of a system setup to have a light theme, then clicking the theme toggle override to dark.
mermaid graph re-initialisation isn't trivial (mermaid doesn't support this) - for now we issue an alert to say that this isn't yet supported. I will introduce the community workaround to achieve this in a future PR.

  • ENH: Mermaid diagram theme set on initialisation, respecting system theme, whether light or dark.
  • ENH: Support initialising mermaid on user behalf if not done so already. This means we can dispense from including mermaid initialisation from the user html file (though this is still supported).
  • BUG: Fixed subgraph ID nesting deduced from '_' - incorrect accounting of subgraph closures (encountered in testing by @SamGriffithsMO).
  • BUG: Missing table text wrap toggle title.
  • Table now sortable by clicking on a column header (toggling between ascending and descending order based on this clicked table column header).
    e.g. order table by descending order or the second row:
  • Table item delimiter now toggleable between <br> (newline) and ; .
    image
    image

Background

Issues

@cpelley cpelley added the enhancement New feature or request label Feb 25, 2025
@cpelley cpelley self-assigned this Feb 25, 2025
@cpelley cpelley changed the title Toggle page theme Visual: toggle page light-dark theme Feb 25, 2025
Base automatically changed from visual_tooltip_table to main February 27, 2025 14:08
@cpelley cpelley marked this pull request as ready for review February 27, 2025 15:00
@cpelley cpelley force-pushed the visual_theme_toggle branch from edb690a to fc02589 Compare February 27, 2025 15:08
@cpelley cpelley added the bug Something isn't working label Feb 27, 2025
@cpelley cpelley requested review from PaulAbernethy and removed request for SamGriffithsMO March 3, 2025 09:45
@cpelley cpelley force-pushed the visual_theme_toggle branch from 6ba0be8 to 30a8e9b Compare March 4, 2025 10:00
@cpelley cpelley force-pushed the visual_theme_toggle branch from 9247037 to a252181 Compare March 4, 2025 10:06
@cpelley cpelley force-pushed the visual_theme_toggle branch from 47c2d1e to 092b7ef Compare March 4, 2025 13:22
@cpelley cpelley force-pushed the visual_theme_toggle branch from 55974b9 to 9fd74b2 Compare March 4, 2025 16:39
@cpelley
Copy link
Collaborator Author

cpelley commented Mar 4, 2025

The visualisation isn't operational and requires a fast iterative development process to reach our goals.
To that end, I'm going to proceed with its merge. Do feel free to post feedback in an issue and I'll address on the next iteration.

@cpelley cpelley force-pushed the visual_theme_toggle branch from a8b2d73 to 2a836f6 Compare March 4, 2025 16:54
@cpelley cpelley force-pushed the visual_theme_toggle branch from 49f368d to 4fa6b96 Compare March 4, 2025 17:09
@cpelley cpelley merged commit 5cef807 into main Mar 4, 2025
@cpelley cpelley deleted the visual_theme_toggle branch March 4, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add dark-mode toggle to DAG visualisation

2 participants