-
Notifications
You must be signed in to change notification settings - Fork 4
Visual: toggle page light-dark theme #86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edb690a to
fc02589
Compare
6ba0be8 to
30a8e9b
Compare
9247037 to
a252181
Compare
47c2d1e to
092b7ef
Compare
55974b9 to
9fd74b2
Compare
Collaborator
Author
|
The visualisation isn't operational and requires a fast iterative development process to reach our goals. |
a8b2d73 to
2a836f6
Compare
49f368d to
4fa6b96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*1 Note how the mermaid diagram does not as of yet change theme with toggle.
The same would be true of a system setup to have a light theme, then clicking the theme toggle override to dark.
mermaid graph re-initialisation isn't trivial (mermaid doesn't support this) - for now we issue an alert to say that this isn't yet supported. I will introduce the community workaround to achieve this in a future PR.
e.g. order table by descending order or the second row:
<br>(newline) and;.Background
Issues