Skip to content

Conversation

@cameronbateman-mo
Copy link
Contributor

Description

Automate jules kgo process found here: https://code.metoffice.gov.uk/trac/jules/wiki/KGOInstall

Script copies from user directories on azure spice and ex machines to the kgo locations on those machines.

Have tested with dummy directories in the appropriate places but would be a good idea to test with an actual install to ensure it has the intended behaviour.

Checklist

  • I have performed a self-review of my own changes

@cameronbateman-mo cameronbateman-mo self-assigned this Aug 13, 2025
@cameronbateman-mo cameronbateman-mo requested a review from a team as a code owner August 13, 2025 10:52
@cameronbateman-mo cameronbateman-mo requested review from ericaneininger and r-sharp and removed request for a team August 13, 2025 10:52
@cameronbateman-mo cameronbateman-mo marked this pull request as draft August 13, 2025 10:53
@cameronbateman-mo
Copy link
Contributor Author

TODO: Future proof by separating out ex into variables

Copy link
Contributor

@ericaneininger ericaneininger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General comments while this PR is still in draft...

  • This script could do with some future proofing. It WILL be run on machines other than EX and potentially other than AzureSpice
    • Keep absolute paths out as far as possible – they will probably change
    • Keep machine specific stuff together as far as possible
    • Stick to generic variable names if possible
  • The final exit (in particular) is unnecessary and may well cause the user's shell to close (irritating). I assume this is here because the original script xsudo'ed as julesadmin and then exited as that user.
  • Nested "" are best avoided as they are confusing to read. An alternative way to delimit environment variables would be ${VARNAME}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants