Fixed color selection for map sketching #4274
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Withalion
requested changes
Dec 23, 2025
Contributor
Withalion
left a comment
Withalion
left a comment
There was a problem hiding this comment.
Now it's probably a good time to create component out of the solutions in MMSketchesDrawer.qml and MMFormPhotoSketchingPageDialog.qml.
📦 Build Artifacts Ready
|
Withalion
reviewed
Jan 9, 2026
Contributor
Withalion
left a comment
Withalion
left a comment
There was a problem hiding this comment.
There is some additional work that needs to be done before we can proceed further
| } | ||
|
|
||
| background: Rectangle { | ||
| property bool isActive: modelData.toLowerCase() === controller.activeColor.toString().toLowerCase() |
Contributor
There was a problem hiding this comment.
activeColor will become the components property (read only preferably) and the component which uses this component will specify onActiveColorChanged to update controller
Contributor
Author
There was a problem hiding this comment.
I don't think that we can make it read only, as we use it in the MMColorButton
📦 Build Artifacts Ready
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified the components inside the MMSKetchesDrawer.
Below there is the fixed UI:
ScreenRecording_12-22-2025.16-00-28_1.MP4