-
Notifications
You must be signed in to change notification settings - Fork 76
Build QGIS dependency as RelWithDebInfo #4267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Pull Request Test Coverage Report for Build 20280785358Details
💛 - Coveralls |
📦 Build Artifacts Ready
|
| endif() | ||
|
|
||
| # For desktop builds, build QGIS as RelWithDebInfo for better debugging | ||
| if (TARGET_TRIPLET STREQUAL "arm64-osx" OR TARGET_TRIPLET STREQUAL "x64-linux") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we somehow update this to be true if the main build is RelWithDebInfo?
Something like:
if ($CMAKE_BUILD_TYPE == RelWithDebInfo)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there is not enought flexibility on VCPKG side. We are unable to access this information. We can either create new "debug" triplets or build it always as RelWithDebInfo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see.. Is it possible to have some cmake variable propagated here? So that we say "-DQGIS_DEBUG=TRUE"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm not really as far as I understand. We can set something up in the triplet files (so creating a different triplet file is an option) or we just keep it in the portfiles.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay I think some solution, which could work, on stackoverflow
fixes #4266
Introduce debug symbols for QGIS for better debugging of various QGIS issues.
P.S: This PR might look scary, but just the first commit is the necessary change, everything else is just a change in formatting.