-
Notifications
You must be signed in to change notification settings - Fork 4
LuisA/258-gift-details-view-fixed-eslint #397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
luisarevalo21
wants to merge
28
commits into
develop
Choose a base branch
from
luisA/258-GiftDetailsView-ESLint
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+38
−9
Open
Changes from 4 commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
a1014e3
fix: eslint for gift details view header return statement and return …
luisarevalo21 595c533
fix: using index for key, switch to reason
luisarevalo21 bf7d152
fix: adjust the handleFeedback in the JSDOCs so its using props
luisarevalo21 bd75e4f
fix removed props from handleFeedback
luisarevalo21 6dde88d
fix: added jsx to the react import
luisarevalo21 12d9ca8
fix: added type file for GiftDetails and passed it into the component
luisarevalo21 5ea8eba
merged develop
luisarevalo21 fc93f1a
reversed eslintignore
luisarevalo21 1f57ce0
fix: removed gift details view from eslint file
luisarevalo21 c4942d1
revered
luisarevalo21 e7a5d53
fixed added txt file
luisarevalo21 209b484
fixed: adjusted the handle amazon link, passing the string
luisarevalo21 9d11be5
fix: removed vscode folder
luisarevalo21 6f7037c
Merge branch 'develop' of https://github.com/LetsGetTechnical/elecret…
luisarevalo21 3920af7
Merge branch 'develop' into luisA/258-GiftDetailsView-ESLint
luisarevalo21 72a77e5
Merge branch 'develop' of https://github.com/LetsGetTechnical/elecret…
luisarevalo21 4385b60
fixed: merged main and added eslint to isValidUrl function;
luisarevalo21 5d6cacd
fix: re-added isValidURL outside the component function
luisarevalo21 cead520
:erge branch 'develop' of https://github.com/LetsGetTechnical/elecret…
luisarevalo21 d5bb9b4
Merge branch 'develop' into luisA/258-GiftDetailsView-ESLint
luisarevalo21 a4e62f3
Merge branch 'develop' of https://github.com/LetsGetTechnical/elecret…
luisarevalo21 1390a0b
resolved conflicts
luisarevalo21 9dc18e3
Merge branch 'develop' into luisA/258-GiftDetailsView-ESLint
shashilo 3332e31
fix: fixed linting issue with the giftDetailsView
luisarevalo21 17814e4
Merge branch 'luisA/258-GiftDetailsView-ESLint' of https://github.com…
luisarevalo21 7498a5c
Merge branch 'develop' into luisA/258-GiftDetailsView-ESLint
shashilo 4f1e5c2
Update components/GiftDetailsView/GiftDetailsView.tsx
shashilo 90880ea
Merge branch 'develop' into luisA/258-GiftDetailsView-ESLint
shashilo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.