Fix: S3 folder deletion not working for some services #367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The S3 folder deletion was failing on some S3-compatible services because the folder's own placeholder object was not being deleted. This was happening because the API for listing folder contents on these services does not include the folder's placeholder object. This commit fixes the issue by adding an explicit `DeleteObject` command to the `deleteBucketFolder` function in `src/main/manage/apis/s3plist.ts`. This command is executed after all the contents and subfolders of the folder have been deleted, ensuring that the folder's own key (e.g., `my-folder/`) is also deleted. This change improves the compatibility of the folder deletion feature with different S3 services.
Kuingsmile
force-pushed
the
dev
branch
2 times, most recently
from
8e0d7d6 to
c917ee3
Compare
Kuingsmile
force-pushed
the
dev
branch
2 times, most recently
from
faec405 to
78ccf30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The S3 folder deletion was failing on some S3-compatible services because the folder's own placeholder object was not being deleted. This was happening because the API for listing folder contents on these services does not include the folder's placeholder object.
This commit fixes the issue by adding an explicit
DeleteObjectcommand to thedeleteBucketFolderfunction insrc/main/manage/apis/s3plist.ts. This command is executed after all the contents and subfolders of the folder have been deleted, ensuring that the folder's own key (e.g.,my-folder/) is also deleted. This change improves the compatibility of the folder deletion feature with different S3 services.