Skip to content

Inovelli: fix parsing of custom cluster attribute - fix parsing of 0xFF values of custom cluster #10065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Koenkk merged 9 commits into from
Sep 23, 2025
Merged

Inovelli: fix parsing of custom cluster attribute - fix parsing of 0xFF values of custom cluster #10065

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
fbb4115
fix for not parsing configuration parameter value
InovelliUSA Sep 22, 2025
9f41fb0
adding special case when UINT8 with a value of 255 (0xFF) is returned…
InovelliUSA Sep 22, 2025
258aaff
removing extra line
InovelliUSA Sep 22, 2025
411f990
Merge branch 'master' into inovelli-4
InovelliUSA Sep 22, 2025
1547f74
[autofix.ci] apply automated fixes
autofix-ci[bot] Sep 22, 2025
b12041f
removing code that converts NaN to 255 because of #1510
InovelliUSA Sep 22, 2025
e5d3b3c
[autofix.ci] apply automated fixes
autofix-ci[bot] Sep 22, 2025
24f42cd
recommended adjustment
InovelliUSA Sep 23, 2025
17f8dd2
fix: cleanup
Nerivec Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/devices/inovelli.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2211,17 +2211,16 @@ const fzLocal = {
if (msg.type === "readResponse") {
return Object.keys(msg.data).reduce((p, c) => {
const key = splitValuesByEndpoint ? `${c}_${msg.endpoint.ID}` : c;
const raw = (msg.data as Record<string | number, unknown>)[c];
if (attributes[key] && attributes[key].displayType === "enum") {
return {
// biome-ignore lint/performance/noAccumulatingSpread: ignored using `--suppress`
...p,
[key]: Object.keys(attributes[key].values).find(
(k) => attributes[key].values[k] === msg.data[Number.parseInt(c, 10)],
),
[key]: Object.keys(attributes[key].values).find((k) => attributes[key].values[k] === raw),
};
}
// biome-ignore lint/performance/noAccumulatingSpread: ignored using `--suppress`
return {...p, [key]: msg.data[Number.parseInt(c, 10)]};
return {...p, [key]: raw};
}, {});
}
return msg.data;
Expand Down
Loading