Add GLSLANG_ prefix to CMake options #3958
Open
+10
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+49
to
+50
| option(GLSLANG_BUILD_EXTERNAL "Build external dependencies in /External" ON) | ||
| option(GLSLANG_BUILD_WERROR "Enable warnings as errors (default is OFF)" OFF) |
Contributor
There was a problem hiding this comment.
I would add a deprecation notice, since changing variable names like this is sure to catch developers off guard.
if (DEFINED BUILD_EXTERNAL)
message(DEPRECATION "The BUILD_EXTERNAL build options has been deprecated and replaced by GLSLANG_BUILD_EXTERNAL, please use the new variable")
endif()Or a similar message to get the point across.
Contributor
|
It looks like this has been attempted before as #2115. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
glslang has two CMake options: BUILD_EXTERNAL and BUILD_WERROR.
If glslang is linked as a library in a project, this is an issue as, on CMake GUI, these options appear as-is, which doesn't indicate where they come from. This can also conflict with other libraries which also do not prefix their CMake options.