fix @omit_null/@omit_empty macros for parametric types #425
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
@omit_nulland@omit_emptymacros to work correctly with parametric types@omit_null struct Foo{T} ... endgeneratedJSON.omit_null(::Type{Foo{T}}) = truewhich only matched when the exact type parameter matchedJSON.omit_null(::Type{<:Foo}) = truewhich correctly matches all instantiations (e.g.,Foo{Int},Foo{String}, etc.)Test plan
🤖 Generated with Claude Code