Skip to content

Conversation

@cmhedrickREI
Copy link
Member

@cmhedrickREI cmhedrickREI commented Nov 26, 2025

Pull Request

Related to GSA/data.gov#5523

About

  • Documents our current API Endpoints in the new Catalog
    • /search
    • /harvest_record/<record_id>
    • /harvest_record/<record_id>/raw
    • /harvest_record/<record_id>/transformed
    • /api/keywords

URL: https://cg-f5a56614-c88e-470c-9f06-ff5fe2d4c98a.sites.pages.cloud.gov/preview/gsa/resources.data.gov/5523-document-api/catalog-api/

PR TASKS

  • The actual code changes.
  • Tests written and passed.
  • Any changes to docs?
  • Any new
    Gemfile
    or
    package.json
    updates to pull in?

@cmhedrickREI cmhedrickREI marked this pull request as ready for review December 1, 2025 17:23
@cmhedrickREI cmhedrickREI requested a review from a team December 1, 2025 17:23
@cmhedrickREI cmhedrickREI changed the title [WIP] Catalog API Docs Catalog API Docs Dec 1, 2025
jbrown-xentity
jbrown-xentity previously approved these changes Dec 1, 2025
Copy link
Contributor

@jbrown-xentity jbrown-xentity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the content changes look good, however it doesn't seem discoverable. I know we may have links on catalog directly to this page, but can we include it in the Guidance (or some other category) so it shows up in some types of search? Maybe with keywords as well? An example would be

@cmhedrickREI
Copy link
Member Author

All the content changes look good, however it doesn't seem discoverable. I know we may have links on catalog directly to this page, but can we include it in the Guidance (or some other category) so it shows up in some types of search? Maybe with keywords as well? An example would be

That was a good idea @jbrown-xentity I made a summary for it so it should now appear in the Guidance section. I hope the tags are okay, they sounded applicable. Also CC @tdlowden for any input and weigh in to.
Screenshot from 2025-12-01 16-28-12
https://cg-f5a56614-c88e-470c-9f06-ff5fe2d4c98a.sites.pages.cloud.gov/preview/gsa/resources.data.gov/5523-document-api/categories/guidance/

@tdlowden
Copy link
Member

tdlowden commented Dec 1, 2025

thanks @cmhedrickREI. In this case "Guidance" is a term with a pretty narrow definition of things from OMB about how to implement memos or laws. So I think putting it under "data tools" might be the the best course of action. Then, we should think about a good place to link to it from the catalog itself. Maybe in the TBD new user guide? i will think on it. But for now can you move to that other section?

@cmhedrickREI
Copy link
Member Author

cmhedrickREI commented Dec 2, 2025

thanks @cmhedrickREI. In this case "Guidance" is a term with a pretty narrow definition of things from OMB about how to implement memos or laws. So I think putting it under "data tools" might be the the best course of action. Then, we should think about a good place to link to it from the catalog itself. Maybe in the TBD new user guide? i will think on it. But for now can you move to that other section?

Sorry for the delay for the quick fix @tdlowden! But I edited the summary category so that way the link appears in the Data Tools section.
Screenshot from 2025-12-02 11-37-29

@cmhedrickREI cmhedrickREI requested review from a team and jbrown-xentity December 2, 2025 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants