Draft: New product query API #267
Conversation
Won't build yet
This handles the API change, and ports the existing creator name check to work with the new product_query.
|
@phlexbot format |
|
No automatic cmake-format fixes were necessary. |
|
Automatic clang-format fixes pushed (commit e8b9e25). |
| "cacheVariables": { | ||
| "CMAKE_EXPORT_COMPILE_COMMANDS": "YES", | ||
| "CMAKE_CXX_STANDARD": "20", | ||
| "CMAKE_CXX_STANDARD": "23", |
There was a problem hiding this comment.
This change will have to wait until the CI container is built with ROOT configured with C++23. Won't be hard to do, just needs to be done.
phlex/core/product_query.cpp
Outdated
| return false; | ||
| } | ||
| // Special case. If other has an unset type_id, ignore this in case it just hasn't been set yet | ||
| if (type_id_.valid() && other.type_id_.valid() && type_id_ != other.type_id_) { |
There was a problem hiding this comment.
Just a general question out of curiosity: under which conditions would this happen?
There was a problem hiding this comment.
The type information isn't populated at construction because it's pulled out of the function signature passed into the HOF. If we ever try and match a query between those points the type_id would be unset.
Also use std::unreachable() instead of kind = "HOW??"s;
beojan
force-pushed
the
new-product-query-api
branch
from
af42dd1 to
dcc0b77
Compare
- Introduce `identifier` - Combine `product_query` and `product_tag` - Express above in terms of `identifier` - Changes to make everything work again
|
@phlexbot format |
|
No automatic cmake-format fixes were necessary. |
|
Automatic clang-format fixes pushed (commit 993ce71). |
3 participants
Part 1 of the new API requiring creator name to be specified.
After implementing this, I'm not sure creator name should be mandatory after all.
(Sorry, even this has turned into a huge PR, and some of the Jsonnet files got auto-formatted as JSON).