Skip to content

Issue#210 'save' icon indication bug #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RealCodeFixes wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Issue#210 'save' icon indication bug #294

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f9cd8bb
fix #210: Only show save button if there are unsaved changes
RealCodeFixes Jan 5, 2026
c707247
Add the change to the CHANGELOG.md
RealCodeFixes Jan 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Fixed
- Fixed inconsistent checklist sorting when the "Move checked items to the bottom" option is enabled ([#59])

### Fixed
- Fixed save icon visibility to be conditional only when changes where made ([#210])

## [1.6.0] - 2025-10-29
### Changed
- Compatibility updates for Android 15 & 16
Expand Down Expand Up @@ -108,6 +111,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
[#190]: https://github.com/FossifyOrg/Notes/issues/190
[#201]: https://github.com/FossifyOrg/Notes/issues/201
[#291]: https://github.com/FossifyOrg/Notes/issues/291
[#210]: https://github.com/FossifyOrg/Notes/issues/210

[Unreleased]: https://github.com/FossifyOrg/Notes/compare/1.6.0...HEAD
[1.6.0]: https://github.com/FossifyOrg/Notes/compare/1.5.0...1.6.0
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/kotlin/org/fossify/notes/activities/MainActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,7 @@ class MainActivity : SimpleActivity() {

saveNoteButton = findItem(R.id.save_note)
saveNoteButton!!.isVisible =
!config.autosaveNotes && showSaveButton && (::mCurrentNote.isInitialized && mCurrentNote.type == NoteType.TYPE_TEXT)
!config.autosaveNotes && showSaveButton && mAdapter?.anyHasUnsavedChanges() == true && (::mCurrentNote.isInitialized && mCurrentNote.type == NoteType.TYPE_TEXT)
}

binding.pagerTabStrip.beVisibleIf(multipleNotesExist)
Expand Down
Loading