Adding migration.md file for Journey migration from the legacy FR SDK #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
george-bafaloukas-forgerock
requested review from
rodrigoareis,
spetrov,
vahancouver and
witrisna
witrisna
approved these changes
Jan 27, 2026
witrisna
left a comment
witrisna
left a comment
There was a problem hiding this comment.
Looks good to me, not sure we need to have all the Callbacks documented, like NameCallback, PasswordCallback, ... since most of the simple Callbacks use similar interface.
May try to feed this MD file to AI and see how well it handles the migration.
vahancouver
requested changes
Jan 30, 2026
Contributor
vahancouver
left a comment
vahancouver
left a comment
There was a problem hiding this comment.
Looks very good.
Just some changes needed in the "modern" swift snippets
|
|
||
| default: | ||
| break | ||
| } |
Contributor
There was a problem hiding this comment.
we can use a better syntax here I think to avoid force unwrapping and to be more concise:
case let failureNode as FailureNode:
Journey/migration.md
Outdated
|
|
||
| switch nextNode { | ||
| case is ContinueNode: | ||
| await handleCallbacks(nextNode as! ContinueNode) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket
JIRA "Interface Mapping - Legacy vs. New Ping SDK (Journey Module)"
Description
Adding the migration.md file for migrating the legacy FR SDK to the new Journey module
Checklist: