Skip to content

Conversation

@arnaud-moncel
Copy link
Member

Definition of Done

General

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Test manually the implemented changes
  • Validate the code quality (indentation, syntax, style, simplicity, readability)

Security

  • Consider the security impact of the changes made

@qltysh
Copy link

qltysh bot commented Dec 11, 2025

3 new issues

Tool Category Rule Count
qlty Structure Function with high complexity (count = 7): run 2
qlty Structure Function with many parameters (count = 4): add_relation 1

@arnaud-moncel arnaud-moncel force-pushed the feat/handle-rpc-spagheti branch from e0bf21c to 863d92f Compare December 11, 2025 17:33
@arnaud-moncel arnaud-moncel force-pushed the feat/handle-rpc-spagheti branch from 863d92f to 12d6546 Compare December 23, 2025 13:39
@arnaud-moncel arnaud-moncel force-pushed the feat/handle-rpc-spagheti branch from 06c3424 to 0a7de88 Compare December 24, 2025 09:53
@arnaud-moncel arnaud-moncel force-pushed the feat/handle-rpc-spagheti branch from 55a26ef to ce5fc5c Compare December 24, 2025 16:08
name
end

def add_relation(collection_customizer, renames, relation_name, relation_definition)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function with many parameters (count = 4): add_relation [qlty:function-parameters]

@arnaud-moncel arnaud-moncel force-pushed the feat/handle-rpc-spagheti branch from 4f22ef6 to cc6b9fb Compare January 5, 2026 14:27
@qltysh
Copy link

qltysh bot commented Jan 5, 2026

Qlty

Coverage Impact

⬆️ Merging this pull request will increase total coverage on main by 0.03%.

Modified Files with Diff Coverage (6)

RatingFile% DiffUncovered Line #s
Coverage rating: A Coverage rating: A
...n_datasource_rpc/lib/forest_admin_datasource_rpc/datasource.rb100.0%
Coverage rating: B Coverage rating: A
...ges/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/agent.rb100.0%
Coverage rating: A Coverage rating: A
...st_admin_rpc_agent/lib/forest_admin_rpc_agent/routes/schema.rb100.0%
Coverage rating: C Coverage rating: C
...lib/forest_admin_datasource_customizer/composite_datasource.rb100.0%
Coverage rating: A Coverage rating: A
...ib/forest_admin_datasource_customizer/datasource_customizer.rb100.0%
New file Coverage rating: A
...source_rpc/lib/forest_admin_datasource_rpc/reconciliate_rpc.rb100.0%
Total100.0%
🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

add_relation(cz, options[:rename], relation_name.to_s, relation_definition)
end
end
end
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function with high complexity (count = 7): run [qlty:function-complexity]

@arnaud-moncel arnaud-moncel merged commit c8fb188 into main Jan 7, 2026
37 checks passed
@arnaud-moncel arnaud-moncel deleted the feat/handle-rpc-spagheti branch January 7, 2026 10:24
forest-bot added a commit that referenced this pull request Jan 7, 2026
# [1.20.0](v1.19.3...v1.20.0) (2026-01-07)

### Features

* handle rpc relations ([#240](#240)) ([c8fb188](c8fb188))
@forest-bot
Copy link
Member

🎉 This PR is included in version 1.20.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants