Skip to content

Conversation

@mountiny
Copy link
Contributor

Reverts #79768

Fixed issues

$ #79986

Screen.Recording.2026-01-20.at.17.22.35.mov

@mountiny mountiny self-assigned this Jan 20, 2026
@mountiny mountiny requested review from a team as code owners January 20, 2026 16:22
@melvin-bot melvin-bot bot requested review from dukenv0307 and trjExpensify and removed request for a team January 20, 2026 16:22
@melvin-bot
Copy link

melvin-bot bot commented Jan 20, 2026

@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@rlinoz rlinoz merged commit bcee23d into main Jan 20, 2026
30 of 32 checks passed
@rlinoz rlinoz deleted the revert-79768-sentry/active-spans-logs branch January 20, 2026 16:30
@melvin-bot melvin-bot bot added the Emergency label Jan 20, 2026
@melvin-bot
Copy link

melvin-bot bot commented Jan 20, 2026

@rlinoz looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@rlinoz
Copy link
Contributor

rlinoz commented Jan 20, 2026

straight revert, no emergency

@rlinoz rlinoz removed the Emergency label Jan 20, 2026
@rlinoz rlinoz changed the title Revert "[No QA][Sentry] Active spans logging" [CP Staging] Revert "[No QA][Sentry] Active spans logging" Jan 20, 2026
@rlinoz rlinoz changed the title [CP Staging] Revert "[No QA][Sentry] Active spans logging" Revert "[No QA][Sentry] Active spans logging" Jan 20, 2026
@codecov
Copy link

codecov bot commented Jan 20, 2026

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/libs/telemetry/activeSpans.ts 100.00% <ø> (ø)
src/libs/telemetry/forwardLogsToSentry.ts 34.37% <0.00%> (-39.99%) ⬇️
... and 7 files with indirect coverage changes

@mountiny mountiny changed the title Revert "[No QA][Sentry] Active spans logging" [NoQA] Revert "[No QA][Sentry] Active spans logging" Jan 20, 2026
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/rlinoz in version: 9.3.5-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/Beamanator in version: 9.3.5-7 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants