[NoQA] Feature: Travel Invoicing - Release 2.4: Update Settlement Frequency Flow

[ikevin127]

Explanation of Change

2.4 Update Settlement Frequency Flow

UX Flow

• In the active state, we show a “Settlement frequency” row with the current value (“Monthly”, “Weekly”, etc.).
• When the admin taps the row:
  • We open a simple selection UI (modal or full‑screen) showing available frequencies.
• When the admin chooses a frequency:
  • We call the Travel Invoicing frequency action.
  • On success, the row shows the new value.

Default Value: When Travel Invoicing is first enabled, the settlement frequency defaults to Monthly (matching CONST.EXPENSIFY_CARD.FREQUENCY_SETTING.MONTHLY). This aligns with typical business billing cycles and mirrors Expensify Card behavior. Users can change to daily if preferred.

Data & Onyx
Current frequency comes from getTravelSettlementFrequency(policy) (e.g., 'monthly', 'weekly').

We map backend values to localized labels via a pure helper: getLocalizedSettlementFrequencyLabel(frequency, translate).

Actions
New function in src/libs/actions/TravelInvoicing.ts:

• updateTravelInvoiceSettlementFrequency({policyID, frequency}):
  • Wraps UpdateTravelInvoiceSettlementFrequency.
  • Returns a Promise and surfaces failures as localized errors.

Components & reuse
Frequency selector:

• Implemented using SelectionList + RadioListItem, same as other simple settings pickers.
• The options array is small and static (e.g., [Daily and Monthly]) aligned with the backend.

WorkspaceTravelInvoicingSection:

• Renders the row using MenuItem with a right‑aligned label for the localized frequency.
• Handles the navigation to the selection screen and updates when Onyx changes.

Testing
Component tests:

• The frequency row displays the correct label for each backend enum.
• Selecting a new frequency triggers updateTravelInvoiceSettlementFrequency with the correct payload.

Fixed Issues

$ #78676
PROPOSAL:

Tests

Note

Right now in order to test the section locally - tester can edit / comment out two blocks of code to be able to see the new section in Workspace Settings > Travel, below is a diff:

DIFF

diff --git a/src/pages/workspace/travel/PolicyTravelPage.tsx b/src/pages/workspace/travel/PolicyTravelPage.tsx
index d40bc2682fd..f024973df16 100644
--- a/src/pages/workspace/travel/PolicyTravelPage.tsx
+++ b/src/pages/workspace/travel/PolicyTravelPage.tsx
@@ -46,17 +46,18 @@ function WorkspaceTravelPage({
     const step = getTravelStep(policy, travelSettings, isBetaEnabled(CONST.BETAS.IS_TRAVEL_VERIFIED), policies, currentUserLogin);
 
     const mainContent = (() => {
-        switch (step) {
-            case CONST.TRAVEL.STEPS.BOOK_OR_MANAGE_YOUR_TRIP:
-                if (isTravelInvoicingEnabled) {
-                    return <WorkspaceTravelInvoicingSection policyID={policyID} />;
-                }
-                return <BookOrManageYourTrip policyID={policyID} />;
-            case CONST.TRAVEL.STEPS.REVIEWING_REQUEST:
-                return <ReviewingRequest />;
-            default:
-                return <GetStartedTravel policyID={policyID} />;
-        }
+        return <WorkspaceTravelInvoicingSection policyID={policyID} />;
+        // switch (step) {
+        //     case CONST.TRAVEL.STEPS.BOOK_OR_MANAGE_YOUR_TRIP:
+        //         if (isTravelInvoicingEnabled) {
+        //             return <WorkspaceTravelInvoicingSection policyID={policyID} />;
+        //         }
+        //         return <BookOrManageYourTrip policyID={policyID} />;
+        //     case CONST.TRAVEL.STEPS.REVIEWING_REQUEST:
+        //         return <ReviewingRequest />;
+        //     default:
+        //         return <GetStartedTravel policyID={policyID} />;
+        // }
     })();
 
     return (
diff --git a/src/pages/workspace/travel/WorkspaceTravelInvoicingSection.tsx b/src/pages/workspace/travel/WorkspaceTravelInvoicingSection.tsx
index d0bb2ec87ca..8b65df8c5ff 100644
--- a/src/pages/workspace/travel/WorkspaceTravelInvoicingSection.tsx
+++ b/src/pages/workspace/travel/WorkspaceTravelInvoicingSection.tsx
@@ -167,9 +167,9 @@ function WorkspaceTravelInvoicingSection({policyID}: WorkspaceTravelInvoicingSec
 
     // If Travel Invoicing is not enabled or no settlement account is configured
     // show the BookOrManageYourTrip component as fallback
-    if (!isTravelInvoicingEnabled || !hasSettlementAccount) {
-        return <BookOrManageYourTrip policyID={policyID} />;
-    }
+    // if (!isTravelInvoicingEnabled || !hasSettlementAccount) {
+    //     return <BookOrManageYourTrip policyID={policyID} />;
+    // }
 
     return (
         <>

Prerequisites

• Log in as a workspace admin with Travel Invoicing enabled.
• Ensure the workspace has a configured settlement account (paymentBankAccountID is set).

Test 1: View Settlement Frequency Row

Steps:

1. Navigate to Workspace > Travel
2. Observe the "Travel Invoicing" section

Expected Results:

• ✅ "Settlement frequency" row is visible with default value displayed as "Monthly"
• ✅ Row shows a right arrow indicating it's clickable

Test 2: Open Frequency Selection Screen

Steps:

1. Tap the "Settlement frequency" row.

Expected Results:

• ✅ Frequency selection RHP opens
• ✅ Header shows "Settlement frequency" with back button
• ✅ Description text is visible: "Choose how often you'll settle your travel invoicing balance."
• ✅ Selectable items list shows "Monthly" and "Daily" options
• ✅ Current frequency is pre-selected

Test 3: Change Frequency (Online)

Steps:

1. Open frequency selection screen.
2. Current frequency shows "Monthly".
3. Tap "Daily" option.

Expected Results:

• ✅ Selection immediately updates to "Daily"

• ✅ Screen navigates back to Travel Invoicing section

• ✅ Settlement frequency row now displays "Daily"

• Verify that no errors appear in the JS console

Offline tests

Test 5: Change Frequency While Offline (Optimistic Update)

Steps:

1. Open the app on the Travel Invoicing section.
2. Toggle offline mode.
3. Tap "Settlement frequency" row.
4. Change from "Monthly" to "Daily".

Expected Results:

• ✅ Optimistic update: Frequency row immediately shows "Daily"
• ✅ Row appears grayed out (pending indicator)
• ✅ No error message

Test 6: Reconnect After Offline Change (Success)

Steps:

1. After Test 5, reconnect to network.
2. Wait for sync.

Expected Results:

• ✅ Pending indicator (gray styling) disappears
• ✅ Frequency row shows "Daily" (confirmed from server)
• ✅ No error / RBR indicator

QA Steps

Same as tests.

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message: https://expensify.slack.com/archives/C01GTK53T8Q/p1768678983597209.
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

web.mov

ios-hybrid.mov

[melvin-bot]

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

1. Look at the code and make sure there are no malicious changes.
2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

[codecov]

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/SCREENS.ts	100.00% <ø> (ø)
src/components/Icon/chunks/illustrations.chunk.ts	0.00% <ø> (ø)
src/components/MenuItem.tsx	87.12% <100.00%> (ø)
src/libs/API/types.ts	100.00% <ø> (ø)
...gation/linkingConfig/RELATIONS/WORKSPACE_TO_RHP.ts	100.00% <ø> (ø)
src/libs/Navigation/linkingConfig/config.ts	75.00% <ø> (ø)
src/libs/TravelInvoicingUtils.ts	100.00% <100.00%> (ø)
...rkspace/travel/CentralInvoicingSubtitleWrapper.tsx	100.00% <100.00%> (ø)
src/ROUTES.ts	12.81% <0.00%> (-0.03%)	⬇️
...gation/AppNavigator/ModalStackNavigators/index.tsx	8.07% <0.00%> (-0.03%)	⬇️
... and 6 more
... and 84 files with indirect coverage changes

[melvin-bot]

@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b58d69d992

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[ikevin127]

🟢 Ready for review!

[joekaufmanexpensify]

Design doc implementation