[No QA] fix: revert connectWithoutView to connect in ModifiedExpenseMessage #79782
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melvin-bot
bot
requested review from
JmillsExpensify
and removed request for
a team
Contributor
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: View the translation diffdiff --git a/src/languages/de.ts b/src/languages/de.ts
index f5c06678..e9524fd7 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -942,7 +942,7 @@ const translations: TranslationDeepObject<typeof en> = {
yourSpace: 'Ihr Bereich',
welcomeToRoom: ({roomName}: WelcomeToRoomParams) => `Willkommen bei ${roomName}!`,
usePlusButton: ({additionalText}: UsePlusButtonParams) => `Verwende die +‑Taste, um eine Ausgabe zu ${additionalText}.`,
- askConcierge: ' Ihr 24/7-KI-Spesenassistent ist hier, um zu helfen.',
+ askConcierge: 'Ihr 24/7 KI-Spesenassistent ist hier, um zu helfen.',
conciergeSupport: 'Ihr 24/7-Spesenassistent',
create: 'Erstellen',
iouTypes: {
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index 31061223..7c666102 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -945,8 +945,8 @@ const translations: TranslationDeepObject<typeof en> = {
yourSpace: 'Votre espace',
welcomeToRoom: ({roomName}: WelcomeToRoomParams) => `Bienvenue dans ${roomName} !`,
usePlusButton: ({additionalText}: UsePlusButtonParams) => `Utilisez le bouton + pour ${additionalText} une dépense.`,
- askConcierge: ' Votre assistant de dépenses IA 24h/24 et 7j/7 est là pour vous aider.',
- conciergeSupport: 'votre assistant de dépenses 24h/24 et 7j/7',
+ askConcierge: 'Votre assistant de notes de frais IA disponible 24h/24 et 7j/7 est là pour vous aider.',
+ conciergeSupport: 'votre assistant de notes de frais 24h/24 et 7j/7',
create: 'Créer',
iouTypes: {
pay: 'payer',
diff --git a/src/languages/it.ts b/src/languages/it.ts
index 363ce9c4..99c3823b 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -942,7 +942,7 @@ const translations: TranslationDeepObject<typeof en> = {
yourSpace: 'Il tuo spazio',
welcomeToRoom: ({roomName}: WelcomeToRoomParams) => `Benvenuto in ${roomName}!`,
usePlusButton: ({additionalText}: UsePlusButtonParams) => `Usa il pulsante + per ${additionalText} una spesa.`,
- askConcierge: ' Il tuo assistente spese AI 24/7 è qui per aiutarti.',
+ askConcierge: 'Il tuo assistente spese IA disponibile 24/7 è qui per aiutarti.',
conciergeSupport: 'il tuo assistente spese 24/7',
create: 'Crea',
iouTypes: {
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index 57270513..d370d588 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -940,8 +940,8 @@ const translations: TranslationDeepObject<typeof en> = {
yourSpace: 'あなたのスペース',
welcomeToRoom: ({roomName}: WelcomeToRoomParams) => `${roomName} へようこそ！`,
usePlusButton: ({additionalText}: UsePlusButtonParams) => `「＋」ボタンを使って経費を${additionalText}してください。`,
- askConcierge: ' あなたの24時間365日対応のAI経費アシスタントがサポートします。',
- conciergeSupport: 'あなたの24時間365日対応の経費アシスタント',
+ askConcierge: 'あなたの24時間365日対応のAI経費アシスタントがお手伝いします。',
+ conciergeSupport: '24時間年中無休の経費アシスタント',
create: '作成',
iouTypes: {
pay: '支払う',
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index 7575a78b..1e00f230 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -942,8 +942,8 @@ const translations: TranslationDeepObject<typeof en> = {
yourSpace: 'Je ruimte',
welcomeToRoom: ({roomName}: WelcomeToRoomParams) => `Welkom bij ${roomName}!`,
usePlusButton: ({additionalText}: UsePlusButtonParams) => `Gebruik de knop + om een uitgave te ${additionalText}.`,
- askConcierge: ' Uw 24/7 AI-uitgavenassistent is er om u te helpen.',
- conciergeSupport: 'uw 24/7-uitgavenassistent',
+ askConcierge: 'Je 24/7 AI-uitgavenassistent is hier om te helpen.',
+ conciergeSupport: 'je 24/7-uitgavenassistent',
create: 'Maken',
iouTypes: {
pay: 'Betalen',
@@ -8003,7 +8003,6 @@ Hier is een *testbon* om je te laten zien hoe het werkt:`,
confirm: 'Afstandstracking negeren',
},
zeroDistanceTripModal: {title: 'Kan geen uitgave aanmaken', prompt: 'Je kunt geen uitgave aanmaken met dezelfde begin- en eindlocatie.'},
-
locationRequiredModal: {
title: 'Locatietoegang vereist',
prompt: 'Sta locatietoegang toe in de instellingen van je apparaat om GPS-afstandsregistratie te starten.',
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index a6c03567..7890acbd 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -941,8 +941,8 @@ const translations: TranslationDeepObject<typeof en> = {
yourSpace: 'Twoja przestrzeń',
welcomeToRoom: ({roomName}: WelcomeToRoomParams) => `Witamy w ${roomName}!`,
usePlusButton: ({additionalText}: UsePlusButtonParams) => `Użyj przycisku +, aby ${additionalText} wydatek.`,
- askConcierge: ' Twój całodobowy asystent wydatków AI jest tutaj, aby pomóc.',
- conciergeSupport: 'twój całodobowy asystent wydatków',
+ askConcierge: 'Twój całodobowy asystent wydatków AI jest tutaj, aby pomóc.',
+ conciergeSupport: 'Twój całodobowy asystent wydatków',
create: 'Utwórz',
iouTypes: {
pay: 'Zapłać',
@@ -7978,7 +7978,6 @@ Oto *paragon testowy*, który pokazuje, jak to działa:`,
confirm: 'Odrzuć śledzenie dystansu',
},
zeroDistanceTripModal: {title: 'Nie można utworzyć wydatku', prompt: 'Nie możesz utworzyć wydatku z tym samym miejscem początkowym i końcowym.'},
-
locationRequiredModal: {
title: 'Wymagany dostęp do lokalizacji',
prompt: 'Aby rozpocząć śledzenie dystansu GPS, zezwól na dostęp do lokalizacji w ustawieniach swojego urządzenia.',
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index 9d91f779..0a9a1699 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -941,7 +941,7 @@ const translations: TranslationDeepObject<typeof en> = {
yourSpace: 'Seu espaço',
welcomeToRoom: ({roomName}: WelcomeToRoomParams) => `Bem-vindo(a) a ${roomName}!`,
usePlusButton: ({additionalText}: UsePlusButtonParams) => `Use o botão + para ${additionalText} uma despesa.`,
- askConcierge: ' Seu assistente de despesas com IA 24/7 está aqui para ajudar.',
+ askConcierge: 'Seu assistente de despesas com IA 24/7 está aqui para ajudar.',
conciergeSupport: 'seu assistente de despesas 24/7',
create: 'Criar',
iouTypes: {
@@ -7988,7 +7988,6 @@ Aqui está um *recibo de teste* para mostrar como funciona:`,
confirm: 'Descartar rastreamento de distância',
},
zeroDistanceTripModal: {title: 'Não é possível criar a despesa', prompt: 'Você não pode criar uma despesa com o mesmo local de partida e de chegada.'},
-
locationRequiredModal: {
title: 'Acesso à localização necessário',
prompt: 'Permita o acesso à localização nas configurações do seu dispositivo para iniciar o rastreamento de distância por GPS.',
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index f343287e..1782ebb2 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -933,8 +933,8 @@ const translations: TranslationDeepObject<typeof en> = {
yourSpace: '您的空间',
welcomeToRoom: ({roomName}: WelcomeToRoomParams) => `欢迎来到 ${roomName}！`,
usePlusButton: ({additionalText}: UsePlusButtonParams) => `使用“+”按钮来${additionalText}一笔报销。`,
- askConcierge: ' 您的 7×24 小时 AI 费用助手随时为您提供帮助。',
- conciergeSupport: '您的 7×24 小时费用助手',
+ askConcierge: '您的 24/7 AI 报销助手随时为您提供帮助。',
+ conciergeSupport: '您全天候的报销助手',
create: '创建',
iouTypes: {
pay: '支付',
@@ -7794,7 +7794,6 @@ ${reportName}
stopGpsTrackingModal: {title: '停止 GPS 追踪', prompt: '你确定吗？这将结束你当前的旅程。', cancel: '恢复追踪', confirm: '停止 GPS 追踪'},
discardDistanceTrackingModal: {title: '丢弃距离跟踪', prompt: '您确定吗？这将放弃您当前的流程，且无法撤销。', confirm: '丢弃距离跟踪'},
zeroDistanceTripModal: {title: '无法创建报销', prompt: '你不能创建起点和终点相同的报销。'},
-
locationRequiredModal: {title: '需要访问位置信息', prompt: '请在设备设置中允许位置访问以开始 GPS 距离跟踪。', allow: '允许'},
androidBackgroundLocationRequiredModal: {title: '需要后台位置访问权限', prompt: '请在设备设置中允许应用使用“始终允许”位置访问权限，以开始 GPS 距离跟踪。'},
preciseLocationRequiredModal: {title: '需要精确位置', prompt: '请在设备设置中启用“精确位置”以开始 GPS 距离跟踪。'},
Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
The functions using allPolicyTags and currentUserLogin are connected to UI components, so they need the regular Onyx.connect to ensure proper re-rendering when the underlying data changes.
marcochavezf
force-pushed
the
marcochavezf/fix-onyx-connect-modified-expense-message
branch
from
b26f924 to
ce2d75c
Compare
Contributor
|
Does this require C+ review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation of Change
This PR reverts the incorrect use of
Onyx.connectWithoutViewback toOnyx.connectinModifiedExpenseMessage.ts.The
connectWithoutViewvariant was incorrectly used forallPolicyTagsandcurrentUserLogin. Since the functions using these values (likegetForReportAction) are called from UI components, they need the regularOnyx.connectto ensure proper re-rendering when the underlying data changes.Using
connectWithoutViewin this context causes stale data issues because the UI won't update when the Onyx data changes.Fixed Issues
Tests
Offline tests
N/A - This change doesn't affect offline behavior
QA Steps
// No QA needed - this is a revert of an incorrect pattern change
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
N/A - No UI changes
Android: mWeb Chrome
N/A - No UI changes
iOS: Native
N/A - No UI changes
iOS: mWeb Safari
N/A - No UI changes
MacOS: Chrome / Safari
N/A - No UI changes