-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Allow creating time expenses from global menu #79780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Allow creating time expenses from global menu #79780
Conversation
…irmation-hours-rate-edit
…irmation-hours-rate-edit
…irmation-hours-rate-edit
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
Explanation of Change
Enables the "time" tab in "Create expense" RHP accessed through global menu, when there is at least one workspace with time tracking enabled. If there are multiple, a list of workspaces to select is displayed.
Checked out from and dependent on: #79214
Fixed Issues
$ #77684
PROPOSAL: N/A
Tests
Scenario 0: No beta enabled.
Scenario 1: No workspaces with time tracking enabled.
Scenario 2: 1 workspace with time tracking enabled.
Scenario 3: Multiple workspaces with time tracking enabled.
Scenario 4: Ensure no regression when creating from the workspace chat/report.
Offline tests
Same as tests but offline.
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari