Skip to content

Conversation

@mrrobot47
Copy link
Member

This pull request updates the site backup logic to better handle backup requests when the site is disabled, especially for the --list and --dash-auth flags. The changes ensure that listing backups and EasyDash API callbacks work even if the site is disabled, and that appropriate error handling and messaging are in place for EasyDash integration.

Improvements for handling site disabled state and EasyDash integration:

  • Modified how get_site_info is called: for --list and --dash-auth operations, it no longer requires the site to be enabled, allowing backup listing and EasyDash authentication to proceed even if the site is disabled.
  • Added logic so that, when --dash-auth is used and the site is disabled, an API callback is sent with an error message, and a clear error is shown to the user. This ensures EasyDash receives the correct failure status.

Code quality and user feedback improvements:

  • Ensured that EasyDash authentication properties are set before any error handling, so API callbacks function correctly in all error scenarios.
  • Improved success messaging by explicitly notifying the user when a backup is created successfully.
  • Refactored the handling of the --dash-auth flag to streamline validation and error reporting.

Copilot AI review requested due to automatic review settings January 7, 2026 08:03
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@mrrobot47 mrrobot47 merged commit ae6786e into EasyEngine:develop Jan 7, 2026
1 of 5 checks passed
@mrrobot47 mrrobot47 deleted the backup/site-disabled-check branch January 7, 2026 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant