Skip to content

feat: enforce specific Docker version and package hold in installatio… #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SteadEXE wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: enforce specific Docker version and package hold in installatio… #101

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 30 additions & 3 deletions apps/website/public/install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
#!/bin/bash

# Docker version to install and maintain
DOCKER_VERSION="28.5.0"

# Detect version from environment variable or default to latest
# Usage with curl (export first): export DOKPLOY_VERSION=canary && curl -sSL https://dokploy.com/install.sh | sh
# Usage with curl (export first): export DOKPLOY_VERSION=feature && curl -sSL https://dokploy.com/install.sh | sh
Expand Down Expand Up @@ -77,7 +80,9 @@ install_dokploy() {
if command_exists docker; then
echo "Docker already installed"
else
curl -sSL https://get.docker.com | sh -s -- --version 28.5.0
curl -sSL https://get.docker.com | sh -s -- --version $DOCKER_VERSION
# Hold docker packages to prevent unintended upgrades
apt-mark hold docker-ce docker-ce-cli docker-ce-rootless-extras
fi

# Check if running in Proxmox LXC container and set endpoint mode
Expand Down Expand Up @@ -277,9 +282,31 @@ update_dokploy() {
# Detect version tag
VERSION_TAG=$(detect_version)
DOCKER_IMAGE="dokploy/dokploy:${VERSION_TAG}"

echo "Updating Dokploy to version: ${VERSION_TAG}"


# Check Docker version and update if necessary
if command -v docker >/dev/null 2>&1; then
current_docker_version=$(docker --version | grep -oP '\d+\.\d+\.\d+' | head -1)
if [ "$current_docker_version" != "$DOCKER_VERSION" ]; then
echo "Docker version mismatch detected. Current: $current_docker_version, Target: $DOCKER_VERSION"
echo "Updating Docker to version $DOCKER_VERSION..."

# Unhold packages to allow update
apt-mark unhold docker-ce docker-ce-cli docker-ce-rootless-extras 2>/dev/null

# Install specific Docker version
curl -sSL https://get.docker.com | sh -s -- --version $DOCKER_VERSION

# Hold packages again
apt-mark hold docker-ce docker-ce-cli docker-ce-rootless-extras

echo "Docker updated to version $DOCKER_VERSION"
else
echo "Docker version $current_docker_version matches target version"
fi
fi

# Pull the image
docker pull $DOCKER_IMAGE

Expand Down
Loading