Impact Dashboard - Cmu Practicum 23 #1075
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented UI for 4 datapoints in homepage (Karina & Ivy)
Installed react-chart js library, implemented ROI line chart following the UI design (Karina & Ivy)
…cTechExchange into cmupracticum23
Implemented impact dashboard Hackathon section as two cards, updated some spacing set up and css styles
mplemented Impact Across Sectors, Volunteer Matching, and Volunteer Experience sections (Karina & Ivy)
Integrated 4 APIs to front end (ROI, estimated impact, number of active volunteer, number of active project) -- Karina & Ivy
…cTechExchange into cmupracticum23
…ct stringfy method
…cTechExchange into cmupracticum23
Implemented responsive UI (mobile screens) for 4 cards - Karina & Ivy
Karina & Ivy
…cTechExchange into cmupracticum23
Completed 3 APIs integrations: ROI, Volunteer Renewal, Volunteer Matching (Karina & Ivy)
Karina & Ivy
Frontend: Implemented 3 sections (ROI, Volunteer Renewal, Volunteer Matching) for mobile views with the most recent API integrations (Karina & Ivy)
Frontend: Implemented mobile views for Volunteer Roles and Hackathons (Karina & Ivy)
…ackathon Frontend: Integrated 3 APIs for Impact of Sectors, Volunteer Roles, Hackathon (Karina & Ivy)
marlonkeating
requested changes
Jan 11, 2024
| } | ||
|
|
||
|
|
||
| class DollarsSaved(models.Model): |
Contributor
There was a problem hiding this comment.
TODO: Refactor impact stats into a more modular key/value store.
| ), | ||
| "project_issue_area": Tag.hydrate_to_json( | ||
| self.id, list(self.project_issue_area.all().values()) | ||
| ), # use this for project Issue area API |
Comment on lines
+1761
to
+1762
| role = TaggableManager(blank=True, through=TaggedVolunteerRole) # volunteer role | ||
| role.remote_field.related_name = "+" # volunteer role |
| overflow: hidden; | ||
| align-self: start; // stops character descenders from getting clipped, weird but works | ||
| } | ||
| // .AggregatedDashboard-title { |
| display: flex; | ||
| flex-direction: column; | ||
| justify-content: space-around; | ||
| // justify-content: center; |
| import React from "react"; | ||
| import { Doughnut } from 'react-chartjs-2'; // References: https://react-chartjs-2.js.org/ | ||
|
|
||
| // 570 Business |
Contributor
There was a problem hiding this comment.
Remove extraneous comment.
Comment on lines
+129
to
+130
| legends[0].fillStyle = "#F79E02"; | ||
| legends[1].fillStyle = "#FDE2B3"; |
Contributor
There was a problem hiding this comment.
These colors are defined above, use those instead or put in a central variable.
| } | ||
|
|
||
| componentDidMount(): void { | ||
| document.getElementById('detailButton').style.display = 'none'; |
Contributor
There was a problem hiding this comment.
TODO: Inline style instead
Contributor
There was a problem hiding this comment.
Why is this being deleted?
| @@ -1,5 +1,4 @@ | |||
| from django.apps import AppConfig | |||
|
|
|||
|
|
|||
marlonkeating
requested changes
Jan 28, 2024
Contributor
There was a problem hiding this comment.
There are serious performance issues with this page as it stands. Multiple components have their own separate API calls, which on aggregate result in a long, fragmented page load where individual charts load at different times. For the sake of performance, I recommend putting all the data behind a single API call (whose payload should be cached since the data does not change often).
Draft
Collaborator
|
Closing this PR as it lives on as #1088 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.