-
Notifications
You must be signed in to change notification settings - Fork 362
fix: only send process tags in first span of first chunk of a network request #7224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Overall package sizeSelf size: 4.39 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 2.0.0 | 68.46 kB | 797.03 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7224 +/- ##
==========================================
- Coverage 84.56% 84.51% -0.06%
==========================================
Files 532 530 -2
Lines 22651 22622 -29
==========================================
- Hits 19154 19118 -36
- Misses 3497 3504 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
BenchmarksBenchmark execution time: 2026-01-13 19:34:12 Comparing candidate commit a23a760 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 291 metrics, 29 unstable metrics. |
637e83a to
26ee8df
Compare
26ee8df to
a23a760
Compare
| const shouldAddProcessTags = this._processTags && !trace._processTagsSent | ||
| if (shouldAddProcessTags) { | ||
| trace._processTagsSent = true | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if the outgoing request fails to send the first spans, this will stay true and the process tags will never be sent no ?
BridgeAR
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was there anything wrong before? Would it not already have worked due to our isFirstSpanInChunk argument?
The test is actually not very helpful in my opinion due to testing just the direct functionality but not the outcome. So by changing the test to test the outcome instead of internal method calls, we can verify the actual behavior and determine the action better in my opinion.
Please update that no matter if the code needs actual adjustment or not as the current test makes assumptions that we should in my opinion not do.
What does this PR do?
Motivation