-
Notifications
You must be signed in to change notification settings - Fork 324
fix(llmobs): Avoid sending empty payloads to the LLMObs endpoint #10372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a56bb43 to
17a164f
Compare
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 7 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.59.0-SNAPSHOT~167c6c5408, baseline=1.59.0-SNAPSHOT~931c40963a
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.094 s) : 0, 1094452
Total [baseline] (10.843 s) : 0, 10843450
Agent [candidate] (1.095 s) : 0, 1094883
Total [candidate] (10.895 s) : 0, 10895429
section appsec
Agent [baseline] (1.264 s) : 0, 1263969
Total [baseline] (11.044 s) : 0, 11044229
Agent [candidate] (1.273 s) : 0, 1272693
Total [candidate] (11.087 s) : 0, 11086602
section iast
Agent [baseline] (1.236 s) : 0, 1236327
Total [baseline] (11.254 s) : 0, 11254325
Agent [candidate] (1.238 s) : 0, 1238230
Total [candidate] (11.305 s) : 0, 11305023
section profiling
Agent [baseline] (1.215 s) : 0, 1214906
Total [baseline] (10.942 s) : 0, 10942398
Agent [candidate] (1.209 s) : 0, 1209409
Total [candidate] (10.948 s) : 0, 10948438
gantt
title petclinic - break down per module: candidate=1.59.0-SNAPSHOT~167c6c5408, baseline=1.59.0-SNAPSHOT~931c40963a
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.191 ms) : 0, 1191
crashtracking [candidate] (1.197 ms) : 0, 1197
BytebuddyAgent [baseline] (657.165 ms) : 0, 657165
BytebuddyAgent [candidate] (658.313 ms) : 0, 658313
GlobalTracer [baseline] (285.351 ms) : 0, 285351
GlobalTracer [candidate] (284.801 ms) : 0, 284801
AppSec [baseline] (33.094 ms) : 0, 33094
AppSec [candidate] (32.882 ms) : 0, 32882
Debugger [baseline] (68.464 ms) : 0, 68464
Debugger [candidate] (68.483 ms) : 0, 68483
Remote Config [baseline] (636.33 µs) : 0, 636
Remote Config [candidate] (642.709 µs) : 0, 643
Telemetry [baseline] (8.988 ms) : 0, 8988
Telemetry [candidate] (9.01 ms) : 0, 9010
Flare Poller [baseline] (3.823 ms) : 0, 3823
Flare Poller [candidate] (3.832 ms) : 0, 3832
section appsec
crashtracking [baseline] (1.191 ms) : 0, 1191
crashtracking [candidate] (1.188 ms) : 0, 1188
BytebuddyAgent [baseline] (689.956 ms) : 0, 689956
BytebuddyAgent [candidate] (695.578 ms) : 0, 695578
GlobalTracer [baseline] (258.197 ms) : 0, 258197
GlobalTracer [candidate] (260.241 ms) : 0, 260241
IAST [baseline] (24.492 ms) : 0, 24492
IAST [candidate] (24.801 ms) : 0, 24801
AppSec [baseline] (172.494 ms) : 0, 172494
AppSec [candidate] (173.615 ms) : 0, 173615
Debugger [baseline] (68.447 ms) : 0, 68447
Debugger [candidate] (67.766 ms) : 0, 67766
Remote Config [baseline] (757.842 µs) : 0, 758
Remote Config [candidate] (779.805 µs) : 0, 780
Telemetry [baseline] (9.35 ms) : 0, 9350
Telemetry [candidate] (9.416 ms) : 0, 9416
Flare Poller [baseline] (3.706 ms) : 0, 3706
Flare Poller [candidate] (3.743 ms) : 0, 3743
section iast
crashtracking [baseline] (1.191 ms) : 0, 1191
crashtracking [candidate] (1.189 ms) : 0, 1189
BytebuddyAgent [baseline] (798.844 ms) : 0, 798844
BytebuddyAgent [candidate] (800.254 ms) : 0, 800254
GlobalTracer [baseline] (258.836 ms) : 0, 258836
GlobalTracer [candidate] (259.456 ms) : 0, 259456
IAST [baseline] (27.239 ms) : 0, 27239
IAST [candidate] (27.269 ms) : 0, 27269
AppSec [baseline] (35.809 ms) : 0, 35809
AppSec [candidate] (35.774 ms) : 0, 35774
Debugger [baseline] (65.849 ms) : 0, 65849
Debugger [candidate] (65.643 ms) : 0, 65643
Remote Config [baseline] (610.731 µs) : 0, 611
Remote Config [candidate] (583.146 µs) : 0, 583
Telemetry [baseline] (8.651 ms) : 0, 8651
Telemetry [candidate] (8.664 ms) : 0, 8664
Flare Poller [baseline] (3.656 ms) : 0, 3656
Flare Poller [candidate] (3.62 ms) : 0, 3620
section profiling
crashtracking [baseline] (1.222 ms) : 0, 1222
crashtracking [candidate] (1.218 ms) : 0, 1218
BytebuddyAgent [baseline] (707.935 ms) : 0, 707935
BytebuddyAgent [candidate] (705.708 ms) : 0, 705708
GlobalTracer [baseline] (222.779 ms) : 0, 222779
GlobalTracer [candidate] (221.862 ms) : 0, 221862
AppSec [baseline] (32.615 ms) : 0, 32615
AppSec [candidate] (32.296 ms) : 0, 32296
Debugger [baseline] (68.437 ms) : 0, 68437
Debugger [candidate] (68.257 ms) : 0, 68257
Remote Config [baseline] (633.097 µs) : 0, 633
Remote Config [candidate] (663.776 µs) : 0, 664
Telemetry [baseline] (9.014 ms) : 0, 9014
Telemetry [candidate] (8.98 ms) : 0, 8980
Flare Poller [baseline] (3.845 ms) : 0, 3845
Flare Poller [candidate] (3.765 ms) : 0, 3765
ProfilingAgent [baseline] (98.062 ms) : 0, 98062
ProfilingAgent [candidate] (96.567 ms) : 0, 96567
Profiling [baseline] (98.646 ms) : 0, 98646
Profiling [candidate] (97.147 ms) : 0, 97147
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.59.0-SNAPSHOT~167c6c5408, baseline=1.59.0-SNAPSHOT~931c40963a
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.084 s) : 0, 1083584
Total [baseline] (8.767 s) : 0, 8767056
Agent [candidate] (1.087 s) : 0, 1087467
Total [candidate] (8.75 s) : 0, 8750401
section iast
Agent [baseline] (1.232 s) : 0, 1231875
Total [baseline] (9.337 s) : 0, 9337375
Agent [candidate] (1.224 s) : 0, 1223659
Total [candidate] (9.317 s) : 0, 9316919
gantt
title insecure-bank - break down per module: candidate=1.59.0-SNAPSHOT~167c6c5408, baseline=1.59.0-SNAPSHOT~931c40963a
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.183 ms) : 0, 1183
crashtracking [candidate] (1.185 ms) : 0, 1185
BytebuddyAgent [baseline] (651.413 ms) : 0, 651413
BytebuddyAgent [candidate] (653.947 ms) : 0, 653947
GlobalTracer [baseline] (282.417 ms) : 0, 282417
GlobalTracer [candidate] (283.781 ms) : 0, 283781
AppSec [baseline] (32.509 ms) : 0, 32509
AppSec [candidate] (32.585 ms) : 0, 32585
Debugger [baseline] (67.232 ms) : 0, 67232
Debugger [candidate] (67.04 ms) : 0, 67040
Remote Config [baseline] (650.823 µs) : 0, 651
Remote Config [candidate] (638.441 µs) : 0, 638
Telemetry [baseline] (8.89 ms) : 0, 8890
Telemetry [candidate] (8.945 ms) : 0, 8945
Flare Poller [baseline] (3.772 ms) : 0, 3772
Flare Poller [candidate] (3.778 ms) : 0, 3778
section iast
crashtracking [baseline] (1.215 ms) : 0, 1215
crashtracking [candidate] (1.199 ms) : 0, 1199
BytebuddyAgent [baseline] (797.115 ms) : 0, 797115
BytebuddyAgent [candidate] (791.474 ms) : 0, 791474
GlobalTracer [baseline] (258.469 ms) : 0, 258469
GlobalTracer [candidate] (256.627 ms) : 0, 256627
AppSec [baseline] (34.698 ms) : 0, 34698
AppSec [candidate] (34.507 ms) : 0, 34507
Debugger [baseline] (65.056 ms) : 0, 65056
Debugger [candidate] (64.812 ms) : 0, 64812
Remote Config [baseline] (578.297 µs) : 0, 578
Remote Config [candidate] (569.681 µs) : 0, 570
Telemetry [baseline] (8.455 ms) : 0, 8455
Telemetry [candidate] (8.479 ms) : 0, 8479
Flare Poller [baseline] (3.566 ms) : 0, 3566
Flare Poller [candidate] (3.537 ms) : 0, 3537
IAST [baseline] (27.11 ms) : 0, 27110
IAST [candidate] (26.938 ms) : 0, 26938
LoadParameters
See matching parameters
SummaryFound 4 performance improvements and 0 performance regressions! Performance is the same for 17 metrics, 15 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~167c6c5408, baseline=1.59.0-SNAPSHOT~931c40963a
dateFormat X
axisFormat %s
section baseline
no_agent (1.194 ms) : 1182, 1206
. : milestone, 1194,
iast (3.175 ms) : 3132, 3219
. : milestone, 3175,
iast_FULL (5.808 ms) : 5751, 5864
. : milestone, 5808,
iast_GLOBAL (3.527 ms) : 3476, 3578
. : milestone, 3527,
profiling (1.899 ms) : 1883, 1914
. : milestone, 1899,
tracing (1.776 ms) : 1761, 1790
. : milestone, 1776,
section candidate
no_agent (1.186 ms) : 1174, 1198
. : milestone, 1186,
iast (3.244 ms) : 3201, 3286
. : milestone, 3244,
iast_FULL (5.715 ms) : 5658, 5772
. : milestone, 5715,
iast_GLOBAL (3.643 ms) : 3585, 3701
. : milestone, 3643,
profiling (1.954 ms) : 1937, 1971
. : milestone, 1954,
tracing (1.799 ms) : 1784, 1814
. : milestone, 1799,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~167c6c5408, baseline=1.59.0-SNAPSHOT~931c40963a
dateFormat X
axisFormat %s
section baseline
no_agent (16.985 ms) : 16818, 17152
. : milestone, 16985,
appsec (19.556 ms) : 19358, 19754
. : milestone, 19556,
code_origins (17.717 ms) : 17543, 17891
. : milestone, 17717,
iast (17.466 ms) : 17292, 17639
. : milestone, 17466,
profiling (18.739 ms) : 18551, 18928
. : milestone, 18739,
tracing (18.709 ms) : 18525, 18894
. : milestone, 18709,
section candidate
no_agent (17.071 ms) : 16900, 17242
. : milestone, 17071,
appsec (18.446 ms) : 18258, 18634
. : milestone, 18446,
code_origins (17.596 ms) : 17421, 17771
. : milestone, 17596,
iast (17.897 ms) : 17720, 18073
. : milestone, 17897,
profiling (18.394 ms) : 18213, 18576
. : milestone, 18394,
tracing (17.429 ms) : 17256, 17601
. : milestone, 17429,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~167c6c5408, baseline=1.59.0-SNAPSHOT~931c40963a
dateFormat X
axisFormat %s
section baseline
no_agent (15.5 s) : 15500000, 15500000
. : milestone, 15500000,
appsec (14.555 s) : 14555000, 14555000
. : milestone, 14555000,
iast (18.077 s) : 18077000, 18077000
. : milestone, 18077000,
iast_GLOBAL (17.571 s) : 17571000, 17571000
. : milestone, 17571000,
profiling (14.728 s) : 14728000, 14728000
. : milestone, 14728000,
tracing (14.733 s) : 14733000, 14733000
. : milestone, 14733000,
section candidate
no_agent (15.518 s) : 15518000, 15518000
. : milestone, 15518000,
appsec (14.49 s) : 14490000, 14490000
. : milestone, 14490000,
iast (18.086 s) : 18086000, 18086000
. : milestone, 18086000,
iast_GLOBAL (17.818 s) : 17818000, 17818000
. : milestone, 17818000,
profiling (15.694 s) : 15694000, 15694000
. : milestone, 15694000,
tracing (14.893 s) : 14893000, 14893000
. : milestone, 14893000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~167c6c5408, baseline=1.59.0-SNAPSHOT~931c40963a
dateFormat X
axisFormat %s
section baseline
no_agent (1.473 ms) : 1461, 1484
. : milestone, 1473,
appsec (3.644 ms) : 3429, 3859
. : milestone, 3644,
iast (2.198 ms) : 2133, 2262
. : milestone, 2198,
iast_GLOBAL (2.249 ms) : 2184, 2314
. : milestone, 2249,
profiling (2.049 ms) : 1996, 2102
. : milestone, 2049,
tracing (2.043 ms) : 1992, 2095
. : milestone, 2043,
section candidate
no_agent (1.473 ms) : 1462, 1485
. : milestone, 1473,
appsec (3.648 ms) : 3433, 3864
. : milestone, 3648,
iast (2.203 ms) : 2138, 2268
. : milestone, 2203,
iast_GLOBAL (2.24 ms) : 2175, 2305
. : milestone, 2240,
profiling (2.08 ms) : 2026, 2134
. : milestone, 2080,
tracing (2.033 ms) : 1982, 2084
. : milestone, 2033,
|
mhlidd
approved these changes
Jan 14, 2026
communication/src/main/java/datadog/communication/serialization/FlushingBuffer.java
Outdated
Show resolved
Hide resolved
17a164f to
ce87923
Compare
ce87923 to
167c6c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Avoids sending payloads to the LLMObs endpoint when the trace does not contain any LLMObs spans.
Motivation
Additional Notes
Add the receiving endpoint and payload size to the debug logs.
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]