-
Notifications
You must be signed in to change notification settings - Fork 324
Allow running wallclock profiler even without tracer #10298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 8 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.59.0-SNAPSHOT~90e82d43f2, baseline=1.59.0-SNAPSHOT~340e03e23d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.082 s) : 0, 1081715
Total [baseline] (8.76 s) : 0, 8759996
Agent [candidate] (1.086 s) : 0, 1086033
Total [candidate] (8.759 s) : 0, 8759196
section iast
Agent [baseline] (1.222 s) : 0, 1221537
Total [baseline] (9.302 s) : 0, 9302028
Agent [candidate] (1.229 s) : 0, 1229044
Total [candidate] (9.362 s) : 0, 9362151
gantt
title insecure-bank - break down per module: candidate=1.59.0-SNAPSHOT~90e82d43f2, baseline=1.59.0-SNAPSHOT~340e03e23d
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.181 ms) : 0, 1181
crashtracking [candidate] (1.189 ms) : 0, 1189
BytebuddyAgent [baseline] (649.888 ms) : 0, 649888
BytebuddyAgent [candidate] (652.644 ms) : 0, 652644
GlobalTracer [baseline] (282.035 ms) : 0, 282035
GlobalTracer [candidate] (283.203 ms) : 0, 283203
AppSec [baseline] (32.811 ms) : 0, 32811
AppSec [candidate] (32.707 ms) : 0, 32707
Debugger [baseline] (66.995 ms) : 0, 66995
Debugger [candidate] (67.377 ms) : 0, 67377
Remote Config [baseline] (642.238 µs) : 0, 642
Remote Config [candidate] (604.863 µs) : 0, 605
Telemetry [baseline] (8.931 ms) : 0, 8931
Telemetry [candidate] (9.03 ms) : 0, 9030
Flare Poller [baseline] (3.779 ms) : 0, 3779
Flare Poller [candidate] (3.782 ms) : 0, 3782
section iast
crashtracking [baseline] (1.191 ms) : 0, 1191
crashtracking [candidate] (1.201 ms) : 0, 1201
BytebuddyAgent [baseline] (789.954 ms) : 0, 789954
BytebuddyAgent [candidate] (795.846 ms) : 0, 795846
GlobalTracer [baseline] (256.063 ms) : 0, 256063
GlobalTracer [candidate] (257.67 ms) : 0, 257670
AppSec [baseline] (34.544 ms) : 0, 34544
AppSec [candidate] (34.242 ms) : 0, 34242
Debugger [baseline] (64.761 ms) : 0, 64761
Debugger [candidate] (64.738 ms) : 0, 64738
Remote Config [baseline] (555.53 µs) : 0, 556
Remote Config [candidate] (574.633 µs) : 0, 575
Telemetry [baseline] (8.462 ms) : 0, 8462
Telemetry [candidate] (8.506 ms) : 0, 8506
Flare Poller [baseline] (3.535 ms) : 0, 3535
Flare Poller [candidate] (3.591 ms) : 0, 3591
IAST [baseline] (27.13 ms) : 0, 27130
IAST [candidate] (27.17 ms) : 0, 27170
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.59.0-SNAPSHOT~90e82d43f2, baseline=1.59.0-SNAPSHOT~340e03e23d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.086 s) : 0, 1086059
Total [baseline] (10.859 s) : 0, 10859189
Agent [candidate] (1.086 s) : 0, 1086166
Total [candidate] (10.806 s) : 0, 10806120
section appsec
Agent [baseline] (1.272 s) : 0, 1272108
Total [baseline] (11.007 s) : 0, 11007172
Agent [candidate] (1.262 s) : 0, 1262478
Total [candidate] (10.979 s) : 0, 10979485
section iast
Agent [baseline] (1.229 s) : 0, 1229229
Total [baseline] (11.228 s) : 0, 11228020
Agent [candidate] (1.227 s) : 0, 1226966
Total [candidate] (11.186 s) : 0, 11186412
section profiling
Agent [baseline] (1.212 s) : 0, 1212002
Total [baseline] (10.919 s) : 0, 10919282
Agent [candidate] (1.212 s) : 0, 1212226
Total [candidate] (10.909 s) : 0, 10909187
gantt
title petclinic - break down per module: candidate=1.59.0-SNAPSHOT~90e82d43f2, baseline=1.59.0-SNAPSHOT~340e03e23d
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.18 ms) : 0, 1180
crashtracking [candidate] (1.193 ms) : 0, 1193
BytebuddyAgent [baseline] (652.839 ms) : 0, 652839
BytebuddyAgent [candidate] (653.492 ms) : 0, 653492
GlobalTracer [baseline] (282.665 ms) : 0, 282665
GlobalTracer [candidate] (282.145 ms) : 0, 282145
AppSec [baseline] (32.642 ms) : 0, 32642
AppSec [candidate] (32.581 ms) : 0, 32581
Debugger [baseline] (67.831 ms) : 0, 67831
Debugger [candidate] (67.767 ms) : 0, 67767
Remote Config [baseline] (650.929 µs) : 0, 651
Remote Config [candidate] (634.254 µs) : 0, 634
Telemetry [baseline] (8.969 ms) : 0, 8969
Telemetry [candidate] (8.959 ms) : 0, 8959
Flare Poller [baseline] (3.762 ms) : 0, 3762
Flare Poller [candidate] (3.78 ms) : 0, 3780
section appsec
crashtracking [baseline] (1.2 ms) : 0, 1200
crashtracking [candidate] (1.18 ms) : 0, 1180
BytebuddyAgent [baseline] (694.679 ms) : 0, 694679
BytebuddyAgent [candidate] (690.375 ms) : 0, 690375
GlobalTracer [baseline] (260.387 ms) : 0, 260387
GlobalTracer [candidate] (257.944 ms) : 0, 257944
AppSec [baseline] (174.997 ms) : 0, 174997
AppSec [candidate] (172.766 ms) : 0, 172766
Debugger [baseline] (66.351 ms) : 0, 66351
Debugger [candidate] (66.91 ms) : 0, 66910
Remote Config [baseline] (813.192 µs) : 0, 813
Remote Config [candidate] (730.004 µs) : 0, 730
Telemetry [baseline] (9.308 ms) : 0, 9308
Telemetry [candidate] (9.175 ms) : 0, 9175
Flare Poller [baseline] (3.843 ms) : 0, 3843
Flare Poller [candidate] (3.67 ms) : 0, 3670
IAST [baseline] (24.899 ms) : 0, 24899
IAST [candidate] (24.413 ms) : 0, 24413
section iast
crashtracking [baseline] (1.187 ms) : 0, 1187
crashtracking [candidate] (1.185 ms) : 0, 1185
BytebuddyAgent [baseline] (793.442 ms) : 0, 793442
BytebuddyAgent [candidate] (792.905 ms) : 0, 792905
GlobalTracer [baseline] (258.337 ms) : 0, 258337
GlobalTracer [candidate] (257.148 ms) : 0, 257148
AppSec [baseline] (34.667 ms) : 0, 34667
AppSec [candidate] (34.68 ms) : 0, 34680
Debugger [baseline] (66.172 ms) : 0, 66172
Debugger [candidate] (65.925 ms) : 0, 65925
Remote Config [baseline] (571.67 µs) : 0, 572
Remote Config [candidate] (591.625 µs) : 0, 592
Telemetry [baseline] (8.611 ms) : 0, 8611
Telemetry [candidate] (8.42 ms) : 0, 8420
Flare Poller [baseline] (3.651 ms) : 0, 3651
Flare Poller [candidate] (3.49 ms) : 0, 3490
IAST [baseline] (27.185 ms) : 0, 27185
IAST [candidate] (27.157 ms) : 0, 27157
section profiling
ProfilingAgent [baseline] (96.844 ms) : 0, 96844
ProfilingAgent [candidate] (96.795 ms) : 0, 96795
crashtracking [baseline] (1.222 ms) : 0, 1222
crashtracking [candidate] (1.218 ms) : 0, 1218
BytebuddyAgent [baseline] (707.229 ms) : 0, 707229
BytebuddyAgent [candidate] (707.911 ms) : 0, 707911
GlobalTracer [baseline] (222.337 ms) : 0, 222337
GlobalTracer [candidate] (222.507 ms) : 0, 222507
AppSec [baseline] (32.371 ms) : 0, 32371
AppSec [candidate] (32.252 ms) : 0, 32252
Debugger [baseline] (68.597 ms) : 0, 68597
Debugger [candidate] (68.031 ms) : 0, 68031
Remote Config [baseline] (638.889 µs) : 0, 639
Remote Config [candidate] (635.146 µs) : 0, 635
Telemetry [baseline] (8.895 ms) : 0, 8895
Telemetry [candidate] (8.873 ms) : 0, 8873
Flare Poller [baseline] (3.722 ms) : 0, 3722
Flare Poller [candidate] (3.716 ms) : 0, 3716
Profiling [baseline] (97.421 ms) : 0, 97421
Profiling [candidate] (97.371 ms) : 0, 97371
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 1 performance regressions! Performance is the same for 18 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~90e82d43f2, baseline=1.59.0-SNAPSHOT~340e03e23d
dateFormat X
axisFormat %s
section baseline
no_agent (18.1 ms) : 17915, 18286
. : milestone, 18100,
appsec (18.403 ms) : 18219, 18587
. : milestone, 18403,
code_origins (17.733 ms) : 17556, 17910
. : milestone, 17733,
iast (17.491 ms) : 17318, 17664
. : milestone, 17491,
profiling (18.769 ms) : 18579, 18959
. : milestone, 18769,
tracing (18.062 ms) : 17879, 18245
. : milestone, 18062,
section candidate
no_agent (19.304 ms) : 19107, 19501
. : milestone, 19304,
appsec (18.551 ms) : 18363, 18739
. : milestone, 18551,
code_origins (17.729 ms) : 17554, 17904
. : milestone, 17729,
iast (17.757 ms) : 17581, 17933
. : milestone, 17757,
profiling (18.786 ms) : 18598, 18974
. : milestone, 18786,
tracing (17.698 ms) : 17523, 17872
. : milestone, 17698,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~90e82d43f2, baseline=1.59.0-SNAPSHOT~340e03e23d
dateFormat X
axisFormat %s
section baseline
no_agent (1.18 ms) : 1168, 1191
. : milestone, 1180,
iast (3.295 ms) : 3247, 3342
. : milestone, 3295,
iast_FULL (5.821 ms) : 5763, 5879
. : milestone, 5821,
iast_GLOBAL (3.556 ms) : 3505, 3607
. : milestone, 3556,
profiling (1.991 ms) : 1974, 2008
. : milestone, 1991,
tracing (1.819 ms) : 1804, 1835
. : milestone, 1819,
section candidate
no_agent (1.177 ms) : 1166, 1188
. : milestone, 1177,
iast (3.151 ms) : 3117, 3185
. : milestone, 3151,
iast_FULL (5.929 ms) : 5870, 5989
. : milestone, 5929,
iast_GLOBAL (3.612 ms) : 3555, 3669
. : milestone, 3612,
profiling (2.066 ms) : 2047, 2084
. : milestone, 2066,
tracing (1.863 ms) : 1847, 1880
. : milestone, 1863,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~90e82d43f2, baseline=1.59.0-SNAPSHOT~340e03e23d
dateFormat X
axisFormat %s
section baseline
no_agent (1.469 ms) : 1458, 1481
. : milestone, 1469,
appsec (3.698 ms) : 3479, 3917
. : milestone, 3698,
iast (2.205 ms) : 2140, 2270
. : milestone, 2205,
iast_GLOBAL (2.248 ms) : 2182, 2314
. : milestone, 2248,
profiling (2.065 ms) : 2011, 2119
. : milestone, 2065,
tracing (2.04 ms) : 1989, 2092
. : milestone, 2040,
section candidate
no_agent (1.471 ms) : 1460, 1483
. : milestone, 1471,
appsec (3.665 ms) : 3449, 3881
. : milestone, 3665,
iast (2.216 ms) : 2150, 2281
. : milestone, 2216,
iast_GLOBAL (2.243 ms) : 2178, 2309
. : milestone, 2243,
profiling (2.061 ms) : 2008, 2113
. : milestone, 2061,
tracing (2.023 ms) : 1972, 2074
. : milestone, 2023,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~90e82d43f2, baseline=1.59.0-SNAPSHOT~340e03e23d
dateFormat X
axisFormat %s
section baseline
no_agent (15.559 s) : 15559000, 15559000
. : milestone, 15559000,
appsec (14.771 s) : 14771000, 14771000
. : milestone, 14771000,
iast (18.413 s) : 18413000, 18413000
. : milestone, 18413000,
iast_GLOBAL (17.872 s) : 17872000, 17872000
. : milestone, 17872000,
profiling (14.993 s) : 14993000, 14993000
. : milestone, 14993000,
tracing (14.718 s) : 14718000, 14718000
. : milestone, 14718000,
section candidate
no_agent (15.325 s) : 15325000, 15325000
. : milestone, 15325000,
appsec (14.516 s) : 14516000, 14516000
. : milestone, 14516000,
iast (18.081 s) : 18081000, 18081000
. : milestone, 18081000,
iast_GLOBAL (17.997 s) : 17997000, 17997000
. : milestone, 17997000,
profiling (14.94 s) : 14940000, 14940000
. : milestone, 14940000,
tracing (14.799 s) : 14799000, 14799000
. : milestone, 14799000,
|
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
Fix the wallclock context filter logic to allow collecting wallclock profiles even with the tracer being disabled and not providing the tracing context.
6997fe7 to
a5f0d36
Compare
0ef488b to
dde4964
Compare
r1viollet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The user might notice more overhead by triggering this, though as this is an explicit setting, we can add a warning in the doc.
What Does This Do
Fix the wallclock context filter logic to allow collecting wallclock profiles even with the tracer being disabled and not providing the tracing context.
Motivation
There are users that want to run profiler without tracer (sic). For those, the wallclock profiling is not possible, ATM. This is fixing that gap.
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: PROF-13347