Open
Conversation
…led through the linechart settings menu for now
…to handle negative numbers
…f time period by assuming new infection case
NXXR
requested changes
Nov 26, 2025
Collaborator
There was a problem hiding this comment.
Looks good code wise.
Design wise I'd like to have the info chip next to the settings cog as a small info tag. otherwise it's quite removed and unintuitive.
I think it should also be part of the settings button, clicking the chip should also open the relevant setting popover.

⚠️ Also make sure this shows up somewhere in the export in #428 depending on which you merge first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Made a settings menu above data cards for the number display settings. Toggle between absolute and relative values (infections per 100k pop), and total number, 1d new infection, 7d new infection. Though the 1D and 7D data still uses the total number of infected.
Related Issues
#318
Design Decisions
Put a settings button that shows a settings popover for the number display when clicked.
Performance & Quality
Checklist
I, the author of this PR checked the following requirements for good software quality:
I, the reviewer checked the following things: