feat: extend update_chart_version.py for downstream charts #731
+201
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new CLI arguments to support updating downstream Helm charts (like lhcbdiracx-charts) that depend on diracx charts: - --app-version: renamed from --diracx-version (kept as alias) - --chart-subdir: support charts at root level or subdirectory - --image-tag-path: configurable YAML path to image tag - --update-dependency: update a dependency version in Chart.yaml - --dependency-app-version: app version to look up in chart index - --dependency-chart-index: URL to chart index (defaults to diracx) The script can now look up chart versions from a Helm repository index.yaml based on the desired appVersion.
chrisburr
force-pushed
the
feat/extend-update-chart-script
branch
from
0120fdf to
f9cb3a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add new CLI arguments to support updating downstream Helm charts (like lhcbdiracx-charts) that depend on diracx charts:
--app-version: renamed from--diracx-version(kept as deprecated alias)--chart-subdir: support charts at root level or subdirectory (default:diracx)--image-tag-path: configurable YAML path to image tag (default:global.images.tag)--update-dependency: update a dependency version in Chart.yaml--dependency-app-version: app version to look up in chart index--dependency-chart-index: URL to chart index (default:https://charts.diracgrid.org/index.yaml)The script can now look up chart versions from a Helm repository index.yaml based on the desired appVersion.
Example usage for diracx (unchanged behavior)
python update_chart_version.py --app-version v0.0.2 # or using deprecated alias python update_chart_version.py --diracx-version v0.0.2Example usage for lhcbdiracx
python update_chart_version.py \ --app-version v0.0.1a50 \ --chart-subdir . \ --image-tag-path diracx.global.images.tag \ --update-dependency diracx \ --dependency-app-version v0.0.2