a11y: checks and buggy dialog fix #14251
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Parth Raiyani <[email protected]> Change-Id: Idb578c0d806081e9706ef9c412d7957962ffdf54
…sibility Signed-off-by: Parth Raiyani <[email protected]> Change-Id: I42ad2118fda5a7da9104f7b805ece2f8c1a7b75d
…bility Signed-off-by: Parth Raiyani <[email protected]> Change-Id: Id59cae723807ea47fcca84858d6fc12f3c01c7c6
Covered Rules: - if element has 'aria-labelledby' then referenced element should exist in DOM - if referenced element is <label> then that label should not point to current element via for attribute(avoid duplicate labelling) - if current element is form element then it must have either <label>, aria-labelledby or aria-label attribute binding. Change-Id: Ic13e65d399765c56a557533809f39c88c99f7bb7 Signed-off-by: Parth Raiyani <[email protected]>
…ty validation - 'BUTTON' should first prioritize aria-labelledby reference Signed-off-by: Parth Raiyani <[email protected]> Change-Id: I2223dcb434d1d35aa0dd5f3f4760076fe888bb64
…eview - add unique IDs to checkbox and radio button elements for improved accessibility - create label instead of span referencing selection element via 'for' attribute when we create radio button or checkbox Change-Id: Ic5191df19aa657b2f254018ef0fa40945d120855 Signed-off-by: Parth Raiyani <[email protected]>
- this change makes findLabelElementById more reliable to remove false positive by only considering numbers in suffix in id Change-Id: I01489abb91cf393a9f04de42bc462c2d06b09dbe Signed-off-by: Parth Raiyani <[email protected]>
Signed-off-by: Parth Raiyani <[email protected]> Change-Id: I2a768a745821db9727063dc92321514f87e09f1f
Change-Id: I415454c092bb8285ca2e9156efe4c4fad5a08f41 Signed-off-by: Parth Raiyani <[email protected]>
Change-Id: I0c135174ff9ee70af18460824d66ccd1bb4dad4c Signed-off-by: Parth Raiyani <[email protected]>
…Page Signed-off-by: Parth Raiyani <[email protected]> Change-Id: I3976b705f2dc619321700bb79ff5ce5fe5a0b2aa
Signed-off-by: Parth Raiyani <[email protected]> Change-Id: Idd222c23551766ab67b224bf275eeecf07d40e42
This comment was marked as spam.
This comment was marked as spam.
eszkadev
reviewed
Jan 29, 2026
| label.id = fixedText.id; | ||
|
|
||
| if (fixedText.visible === false) { | ||
| window.L.DomUtil.addClass(label, 'hidden'); |
Contributor
There was a problem hiding this comment.
I'm concerned here: it that will need some dynamic "show" ?
We hide things in postProcess I think. It applies properties to the root element inside widget. So we should:
- synchronize hidden / disabled state with root element
- use CSS with selector:
parent > childto apply state using paren't property
not urgent but might happen in the future possibly?
Contributor
|
has conflict |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This changes add new check for a11y cypress tests and also contains fix for buggy dialogs
Set of core patches required:
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay