-
Notifications
You must be signed in to change notification settings - Fork 6
Usher updates #244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 5.x
Are you sure you want to change the base?
Usher updates #244
Conversation
agarzola
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes in this PR look sane to me, but I don’t know enough about it to approve this PR. I’ll let those more familiar with our use of Usher give this a proper review.
Thanks for taking the initiative to do this, @apotek!
I have updated the composer.json in Imprivata to use this branch rather than the release and will report back with testing findings. Thank you for taking a look @agarzola I really appreciate it. |
mmatsoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Change look good to me, too. If it works on Imprivata, then all the better! Thanks, @apotek!
|
Thanks @mmatsoo ! I am going to use this branch in Imprivata for a week and make sure there are no new issues. After that, I'll merge to main. If anyone wants to be an early adopter, they can require it in composer as |
Description
This adds some long-overdue updates to Usher.
Motivation / Context
Usher composer requirements are beginning to block some dev tooling updates in builds where we include Usher.
Testing Instructions / How This Has Been Tested
Use this branch in your project by using composer to require chromatic/usher:dev-usher-up