-
Notifications
You must be signed in to change notification settings - Fork 9
BENTLEY_materials_planar_fill #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
...ndor/BENTLEY_materials_planar_fill/schema/material.BENTLEY_materials_planar_fill.schema.json
Show resolved
Hide resolved
|
This is looking great to me. Do you have an implementation or is that still in progress? |
PR is up for review on iTwin.js: iTwin/itwinjs-core#8906 CesiumJS implementation is beginning. |
weegeekps
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@markschlosseratbentley Cool, then I'm okay with this being merged into vendor-extensions. I just wanted to ensure that we had at least tested the implementation at least once in a dog fooding exercise.
However, you need to update the copyright. See my other comment.
Co-authored-by: Adam Morris <adam@cesium.com>
I went ahead and added the link to the iTwin.js PR as a known implementation. |
weegeekps
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
Introduction
This PR describes an extension to glTF which meets the needs of Bentley Systems for customizing fill behavior for planar polygons.
Overview
Two- and three-dimensional planar polygons with filled interiors are fundamental elements in many 3D modeling and computer-aided design (CAD) environments. The
BENTLEY_materials_planar_fillextension allows the behavior of a polygon's interior fill to be customized with the intent of being able to indicate a variety of meanings useful to CAD applications.This specification describes a minimal extension sufficient to meet Bentley Systems' requirements, with some suggestions for how it might be broadened and/or generalized while retaining a focus on CAD visualization.