Skip to content

Conversation

@CathalMullan
Copy link
Collaborator

Resolves #354

The "used in feature" diagnostic now includes plain dep enablements, like "foo" instead of "dep:foo".

shear/unused_optional_dependency

  ⚠ unused optional dependency `smol`
    ╭─[sqlx-macros-core/Cargo.toml:64:1]
 63 │ async-std = { workspace = true, optional = true }
 64 │ smol = { workspace = true, optional = true }
    · ──┬─
    ·   ╰── not used in code
 65 │ tokio = { workspace = true, optional = true }
    ╰────

Advice:
  ☞ removing an optional dependency may be a breaking change

Advice:
  ☞ used in feature `_rt-smol`
    ╭─[sqlx-macros-core/Cargo.toml:17:13]
 16 │ _rt-async-std = ["async-std", "sqlx-core/_rt-async-std"]
 17 │ _rt-smol = ["smol", "sqlx-core/_rt-smol"]
    ·             ───┬──
    ·                ╰── enabled here
 18 │ _rt-tokio = ["tokio", "sqlx-core/_rt-tokio"]
    ╰────

@Boshen
Copy link
Owner

Boshen commented Dec 8, 2025

Nice!

@Boshen Boshen merged commit ba58b1e into Boshen:main Dec 8, 2025
1 check passed
@Boshen Boshen mentioned this pull request Dec 8, 2025
@CathalMullan CathalMullan deleted the hidden branch December 8, 2025 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Plain dependency enablements aren't being correctly collected

2 participants