Skip to content

Conversation

@Bisaloo
Copy link
Contributor

@Bisaloo Bisaloo commented Apr 6, 2025

While reading the book, I noticed some typos as well as unrendered R code.

This PR is fixing this.

I might have misunderstood some things so please let me know if that's the case and I should revert some changes.

@lshep
Copy link
Contributor

lshep commented Apr 7, 2025

Thanks. Most changes were spacing and the few typo corrections and punctuation changes look good. It looks like there is one typo in your changes regarding namespace header, there is an extra i https://github.com/Bioconductor/pkgrevdocs/pull/142/files#diff-f4d795fac895f8385ce8d646818e73bfcdef8ccca797c5ef07f1d61d9722f1e7R239 . Could you please correct that and then we can merge.

@Bisaloo
Copy link
Contributor Author

Bisaloo commented Apr 7, 2025

Thanks for the careful review! It's now fixed.

@lshep lshep merged commit 8a0a4e3 into Bioconductor:devel Apr 7, 2025
1 check passed
@Bisaloo Bisaloo deleted the typos-20250406 branch April 7, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants