Skip to content

Conversation

@dzver
Copy link
Member

@dzver dzver commented Dec 12, 2025

Fixes DOTCOM-15427

Check 197503-ghe-Automattic/wpcom for details

Proposed changes:

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • You'll need a dev blog for this
jetpack build --production plugins/jetpack
jetpack rsync jetpack [email protected]:/srv/htdocs/wp-content/plugins/jetpack

You can add Personal, Premium, and Business plans and ensure nothing changes. Given that the feature gating on Jetpack is not really functional for anything other than Jetpack Forms, it's not easy to test.

You can:

  • Add a Jetpack form that has a file upload
  • Bu following the sticker approach in 197503-ghe-Automattic/wpcom, you can see that the file upload becomes gated behind an upsell

All the other features will need subsequent upsells to become hidden behind upsells on Atomic.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 12, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack or WordPress.com Site Helper), and enable the update/add-features-for-q1-gating-experiment branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack update/add-features-for-q1-gating-experiment

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added [Feature] WPCOM API [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Wpcomsh labels Dec 12, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 12, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen as soon as you deploy your changes after merging this PR (PCYsg-Jjm-p2).
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly:
    • Scheduled release: January 6, 2026

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.


Wpcomsh plugin:

  • Next scheduled release: Atomic deploys happen twice daily on weekdays (p9o2xV-2EN-p2)

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Dec 12, 2025
@jp-launch-control
Copy link

jp-launch-control bot commented Dec 12, 2025

Code Coverage Summary

Coverage changed in 3 files.

File Coverage Δ% Δ Uncovered
projects/plugins/wpcomsh/wpcom-features/class-wpcom-features.php 39/75 (52.00%) -4.92% 8 💔
projects/plugins/jetpack/sal/class.json-api-site-base.php 11/327 (3.36%) -0.05% 5 💔
projects/plugins/jetpack/json-endpoints/class.wpcom-json-api-get-site-endpoint.php 486/639 (76.06%) 0.11% 0 💚

Full summary · PHP report · JS report

If appropriate, add one of these labels to override the failing coverage check: Covered by non-unit tests Use to ignore the Code coverage requirement check when E2Es or other non-unit tests cover the code Coverage tests to be added later Use to ignore the Code coverage requirement check when tests will be added in a follow-up PR I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage.

@dzver dzver force-pushed the update/add-features-for-q1-gating-experiment branch 3 times, most recently from 55c16b9 to 30cae05 Compare December 17, 2025 09:20
@dzver dzver force-pushed the update/add-features-for-q1-gating-experiment branch from 3757c02 to 48e1522 Compare December 18, 2025 06:58
@dzver dzver added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Review This PR is ready for review. and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Dec 18, 2025
@dzver dzver merged commit 416f87e into trunk Dec 18, 2025
73 of 74 checks passed
@dzver dzver deleted the update/add-features-for-q1-gating-experiment branch December 18, 2025 09:30
@github-actions github-actions bot removed the [Status] Needs Review This PR is ready for review. label Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] WPCOM API [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Wpcomsh [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants