fix(js): Fix typo in String.prototype.md5()#349
Open
tomushkin wants to merge 1 commit intoAlinto:masterfrom
Open
fix(js): Fix typo in String.prototype.md5()#349tomushkin wants to merge 1 commit intoAlinto:masterfrom
tomushkin wants to merge 1 commit intoAlinto:masterfrom
Conversation
This was causing some gravatars to not display properly
Member
|
Hi ! Thank you for your contribution |
Author
|
Hello, the inner md5 function already does toLowerCase() on the hash. The public function does it on the input which must be a mistake: var md5 = function(s){...; return i.toLowerCase();};
return md5(this.toLowerCase());I moved the second call from |
e4c98fd to
2258d5c
Compare
|
seems correct, replacing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The minified String.prototype.md5() implementation is missing a couple of backslashes in
replace(s/rn//g, "n")causing contacts that contain "rn" to not have the gravatar displayed.Also it's doing toLowerCase() on its input, which doesn't seem correct.