transientDefault warning #751
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halotukozak
force-pushed
the
transient-default-warn-when-value-not-provided
branch
from
0258539 to
deb5dbb
Compare
Member
Author
sebaciv
reviewed
Jan 2, 2026
| def isTransientDefault(param: ApplyParam): Boolean = | ||
| param.defaultValue.nonEmpty && hasAnnotation(param.sym, TransientDefaultAnnotType) | ||
|
|
||
| def isTransientDefault(param: ApplyParam, warnIfDefaultNotProvided: Boolean = false): Boolean = |
Contributor
There was a problem hiding this comment.
Prefer overloading to avoid binary compatibility problems
There was a problem hiding this comment.
Pull request overview
This PR adds compile-time validation for the @transientDefault annotation to ensure it is only used on parameters that have default values. Previously, the annotation would silently have no effect when applied to parameters without defaults.
Key Changes:
- Added compile-time warning/error when
@transientDefaultis used without a default value - Refactored the
isTransientDefaultmethod to support optional validation - Added test coverage for both valid and invalid usage of
@transientDefault
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| GenCodecMacros.scala | Refactored isTransientDefault to validate that @transientDefault has a default value and emit an error when missing |
| NotUsedTransientDefault.scala | Added test suite to verify compile-time validation of @transientDefault annotation usage |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
macros/src/main/scala/com/avsystem/commons/macros/serialization/GenCodecMacros.scala
Outdated
Show resolved
Hide resolved
macros/src/main/scala/com/avsystem/commons/macros/serialization/GenCodecMacros.scala
Show resolved
Hide resolved
core/src/test/scala/com/avsystem/commons/serialization/NotUsedTransientDefault.scala
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@transientDefault should not compile when default value was not provided