Skip to content

Require clang-format-19 #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
onelxj merged 1 commit into from
Feb 26, 2025
Merged

Require clang-format-19 #94

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions check-code-style/check_style.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,9 +94,7 @@ check_clang_format() {
# The command `clang-format --version` behaves differently on different OS.
# For example, on Ubuntu this command will message us out with the following
# content:
# Ubuntu clang-format version 12.0.0-3ubuntu1~20.04.4
# On macos:
# clang-format version 13.0.0
# Ubuntu clang-format version 19.1.7 (++20250114103238+cd708029e0b2-1~exp1~20250114103342.77)
# That's why commands like `cut`, `head`, `tr` are not the way we wanna grab
# the version's numbers.

Expand All @@ -106,9 +104,10 @@ check_clang_format() {
# Retain the part after the `version ` (including space too).
clang_format_version_found=${clang_format_version_output##*version }

# Retain the part before `-`.
clang_format_version_found=${clang_format_version_found%-*}
clang_format_version_required="13.0.0"
# Retain the part before ` `.
clang_format_version_found=${clang_format_version_found% *}

clang_format_version_required="19.1.7"

check_version ${clang_format_version_found} ${clang_format_version_required}

Expand Down